Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINTENANCE] Enable spark tests for docs #3625

Merged

Conversation

Shinnnyshinshin
Copy link
Contributor

@Shinnnyshinshin Shinnnyshinshin commented Nov 2, 2021

Changes proposed in this pull request:

  • This is a small PR in preparation for GREAT-223, which will bring Bring How to Create a Batch of Data from an In Memory Spark or Pandas Dataframe doc under test.
  • This PR disables the --no-spark flag we used to have for the docusaurus tests by allowing Spark tests to use an existing helper function get_or_create_spark_session() instead of trying to load the findspark package, which was causing problems in Azure.
  • Since the test script changed, I've also updated the line numbers referenced in the documentation accordingly.

Checklist

  • My code follows the Great Expectations style guide
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added unit tests where applicable and made sure that new and existing tests are passing.
  • I have run any local integration tests and made sure that nothing is broken.

@netlify
Copy link

netlify bot commented Nov 2, 2021

✔️ Deploy Preview for niobium-lead-7998 ready!

🔨 Explore the source changes: c8aab15

🔍 Inspect the deploy log: https://app.netlify.com/sites/niobium-lead-7998/deploys/61817f8b209cc3000887bcb0

😎 Browse the preview: https://deploy-preview-3625--niobium-lead-7998.netlify.app

@Shinnnyshinshin Shinnnyshinshin self-assigned this Nov 2, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2021

HOWDY! This is your friendly 🤖 CHANGELOG bot 🤖

Please don't forget to add a clear and succinct description of your change under the Develop header in docs_rtd/changelog.rst, if applicable. This will help us with the release process. See the Contribution checklist in the Great Expectations documentation for the type of labels to use!

Thank you!

Copy link
Contributor

@alexsherstinsky alexsherstinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Shinnnyshinshin Shinnnyshinshin merged commit 06f39ff into develop Nov 2, 2021
@Shinnnyshinshin Shinnnyshinshin deleted the MAINTENANCE/GREAT-223/enable-spark-doc-test-flag branch November 2, 2021 19:47
Shinnnyshinshin pushed a commit that referenced this pull request Nov 3, 2021
…-tests-for-docs

* develop:
  DevRel - docs fixes (#3498)
  Remove --no-spark flag from docs tests (#3625)
  [DOCS] Choosing and configuring DataConnectors (#3533)
  [BUGFIX] Be able to use spark execution engine with spark reuse flag (#3541)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants