Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRJVM208 - Avoid spring repository calls in loops with Stream #157

Closed
wants to merge 3 commits into from
Closed

CRJVM208 - Avoid spring repository calls in loops with Stream #157

wants to merge 3 commits into from

Conversation

ibhmefteh
Copy link

No description provided.

@kerimboukadida
Copy link

MicrosoftTeams-image (3)

@MP-Aubay MP-Aubay added java 🏆 challenge2023 🏆 Work done during the ecoCode Challenge 2023 labels Apr 6, 2023
@MP-Aubay
Copy link
Contributor

MP-Aubay commented Apr 6, 2023

Duplicate #151

@dedece35 dedece35 mentioned this pull request Apr 16, 2023
Closed
@dedece35
Copy link
Member

Issue #112

@dedece35
Copy link
Member

dedece35 commented Apr 16, 2023 •
edited
Loading

Hi @kerimboukadida and @ibhmefteh,

sorry but there is another PR on the same issue.
This PR #151 is a little more advanced than your PR (error in your check tab, implementation clearer, compiler errors)

@dedece35 dedece35 added 🗃️ rule rule improvment or rule development or bug 👀 👀 review done 👀 👀 review done - waiting for changes labels Apr 17, 2023
@dedece35 dedece35 self-requested a review April 17, 2023 20:49
@ibhmefteh ibhmefteh force-pushed the CRJVM208-java-4ko-AvoidSpringRepositoryCallInStreamCheck branch from 7c7c009 to 07f8d74 Compare May 8, 2023 11:05
@github-actions
Copy link

This PR has been automatically marked as stale because it has no activity for 30 days.
Please add a comment if you want to keep the issue open. Thank you for your contributions!

@github-actions github-actions bot added the stale label Jun 24, 2023
@dedece35 dedece35 mentioned this pull request Aug 25, 2023
Open
@dedece35 dedece35 added 👀 👀 waiting commiter 👀 👀 duplicate This issue or pull request already exists and removed 👀 👀 review done 👀 👀 review done - waiting for changes stale 👀 👀 waiting commiter 👀 👀 labels Sep 22, 2023
@github-actions
Copy link

This PR has been automatically marked as stale because it has no activity for 30 days.
Please add a comment if you want to keep the issue open. Thank you for your contributions!

@github-actions github-actions bot added the stale label Oct 23, 2023
@dedece35 dedece35 mentioned this pull request Oct 27, 2023
Merged
@dedece35
Copy link
Member

I close this PR because of stale status.
I decided to create a new PR #238 to merge code of this PR (#157 ) and #151 one with also some improvements : check content of #238

@dedece35 dedece35 closed this Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dedece35 dedece35 Awaiting requested review from dedece35

Assignees
No one assigned
Labels
🗃️ rule rule improvment or rule development or bug 🏆 challenge2023 🏆 Work done during the ecoCode Challenge 2023 duplicate This issue or pull request already exists java stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ibhmefteh @kerimboukadida @MP-Aubay @dedece35