-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE 112] [CRJVM208] get stale code of PRs 151 and 157 to merge them into this… #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… branch and upgrade code
dedece35
added
🚀 enhancement
New feature or request
🗃️ rule
rule improvment or rule development or bug
java
🏆 challenge2023 🏆
Work done during the ecoCode Challenge 2023
🔥 in progress 🔥
labels
Oct 27, 2023
This was referenced Oct 27, 2023
dedece35
changed the title
[ISSUE 112] get stale code of PRs 151 and 157 to merge them into this…
[ISSUE 112] [CRJVM208] get stale code of PRs 151 and 157 to merge them into this…
Oct 27, 2023
utarwyn
reviewed
Dec 4, 2023
ecocode-rules-specifications/src/main/rules/EC1/java/EC1.asciidoc
Outdated
Show resolved
Hide resolved
Co-authored-by: Maxime Malgorn <9255967+utarwyn@users.noreply.github.com>
Co-authored-by: Maxime Malgorn <9255967+utarwyn@users.noreply.github.com>
utarwyn
previously approved these changes
Dec 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice work 💯
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🗃️ rule
rule improvment or rule development or bug
🏆 challenge2023 🏆
Work done during the ecoCode Challenge 2023
java
🚀 enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… branch and upgrade code
this PR merge old 2 stale PRs #151 and #157 and also upgrade the code to improve "AvoidSpringRepositoryCallInLoopCheck" with Stream code
tests on real test java project to merge after this current PR : https://github.com/green-code-initiative/ecoCode-java-test-project/pull/13