Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE 112] [CRJVM208] get stale code of PRs 151 and 157 to merge them into this… #238

Merged
merged 13 commits into from
Dec 4, 2023

Conversation

dedece35
Copy link
Member

@dedece35 dedece35 commented Oct 27, 2023

… branch and upgrade code

this PR merge old 2 stale PRs #151 and #157 and also upgrade the code to improve "AvoidSpringRepositoryCallInLoopCheck" with Stream code

tests on real test java project to merge after this current PR : https://github.com/green-code-initiative/ecoCode-java-test-project/pull/13

@dedece35 dedece35 added 🚀 enhancement New feature or request 🗃️ rule rule improvment or rule development or bug java 🏆 challenge2023 🏆 Work done during the ecoCode Challenge 2023 🔥 in progress 🔥 labels Oct 27, 2023
@dedece35 dedece35 requested review from jycr and MP-Aubay October 27, 2023 16:01
@dedece35 dedece35 self-assigned this Oct 27, 2023
@dedece35 dedece35 linked an issue Oct 27, 2023 that may be closed by this pull request
@dedece35 dedece35 marked this pull request as draft October 27, 2023 16:05
@dedece35 dedece35 changed the title [ISSUE 112] get stale code of PRs 151 and 157 to merge them into this… [ISSUE 112] [CRJVM208] get stale code of PRs 151 and 157 to merge them into this… Oct 27, 2023
@dedece35 dedece35 marked this pull request as ready for review November 18, 2023 21:57
@dedece35 dedece35 marked this pull request as draft November 18, 2023 21:58
@dedece35 dedece35 requested review from utarwyn and jhertout December 1, 2023 19:40
@dedece35 dedece35 marked this pull request as ready for review December 1, 2023 19:40
@dedece35 dedece35 removed the request for review from jycr December 1, 2023 21:21
Co-authored-by: Maxime Malgorn <9255967+utarwyn@users.noreply.github.com>
dedece35 and others added 2 commits December 4, 2023 09:58
Co-authored-by: Maxime Malgorn <9255967+utarwyn@users.noreply.github.com>
@dedece35 dedece35 requested review from utarwyn and jycr and removed request for jycr December 4, 2023 09:22
utarwyn
utarwyn previously approved these changes Dec 4, 2023
Copy link
Member

@utarwyn utarwyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice work 💯

Copy link

sonarqubecloud bot commented Dec 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

98.1% 98.1% Coverage
0.0% 0.0% Duplication

@dedece35 dedece35 merged commit 20d1826 into main Dec 4, 2023
3 checks passed
@dedece35 dedece35 deleted the ISSUE_112_recup branch December 4, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🗃️ rule rule improvment or rule development or bug 🏆 challenge2023 🏆 Work done during the ecoCode Challenge 2023 java 🚀 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CRJVM208] [Java] Avoid spring repository calls in loops with Stream
2 participants