structmatcher: Use MatchStruct matcher in deprecated implementations #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also removes the dependency on ginkgo, which will improve compatibility with ginkgo v2. Authored-by: David Sharp <dsharp@vmware.com>
jimmyyih
approved these changes
Apr 20, 2022
|
@jimmyyih If this looks good, can you merge it? I don't have write access to this repository (anymore?). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're trying to upgrade to ginkgo/v2, but structmatcher imports ginkgo v1. We can avoid the issue by not importing ginkgo at all. In this case, structmatcher only called Fail() in the deprecated ExpectXxx() functions. These can be replaced with using the MatchStruct() GomegaMatcher.
More info: onsi/ginkgo#875