Remove ginkgo v1 reference from testhelper package #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ginkgo v1 reference in testhelper's function.go was making the testhelper package incompatible with ginkgo v2. Remove the ginkgo v1 reference and replace the Fail() calls with equivalent gomega Expect calls.
|
This goes along the same lines as #63. With that PR and this PR, gp-common-go-libs test packages should be compatible with ginkgo v2. |
shivzone
approved these changes
Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ginkgo v1 reference in testhelper's function.go was making the
testhelper package incompatible with ginkgo v2. Remove the ginkgo v1
reference and replace the Fail() calls with equivalent gomega Expect
calls.