Resolve the issues reported in #110 with bad reporting of errors #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashleyfrieze
commented
Apr 18, 2017
| @@ -16,7 +16,7 @@ allprojects { | |||
| dependencies { | |||
| compile group: 'junit', name: 'junit', version: '4.12' | |||
| testCompile group: 'org.hamcrest', name: 'hamcrest-library', version: '1.3' | |||
| testCompile group: 'org.mockito', name: 'mockito-core', version: '1.10.19' | |||
| testCompile group: 'org.mockito', name: 'mockito-core', version: '2.7.22' | |||
There was a problem hiding this comment.
Upgraded to the latest Mockito to allow easier argThat
ashleyfrieze
commented
Apr 18, 2017
| @@ -257,7 +258,7 @@ public Description getDescription() { | |||
|
|
|||
| @Override | |||
| public void run(final RunNotifier notifier) { | |||
| this.rootSuite.run(notifier); | |||
| this.rootSuite.run(new RunNotifierReporting(notifier)); | |||
There was a problem hiding this comment.
The real run notifier is wrapped by the reporting interface.
Codecov Report
@@ Coverage Diff @@
## master #111 +/- ##
============================================
+ Coverage 99.4% 99.43% +0.03%
- Complexity 312 331 +19
============================================
Files 39 40 +1
Lines 669 714 +45
Branches 16 21 +5
============================================
+ Hits 665 710 +45
Partials 4 4
|
ashleyfrieze
commented
Apr 18, 2017
| suite.runChild(child, runNotifier); | ||
| private static void abortOnFailureChildRunner(final Suite suite, | ||
| final RunReporting<Description, Failure> reporting) { | ||
| FailureDetectingRunDecorator<Description, Failure> decoratedReporting = |
There was a problem hiding this comment.
This decorator simplifies the method a lot. We no longer add a listener to the RunNotifier but instead wrap the Reporting with a sentinel.
ashleyfrieze
commented
Apr 18, 2017
| .filter(child -> !child.isEffectivelyIgnored()) | ||
| .findFirst() | ||
| .isPresent(); | ||
| .anyMatch(child -> !child.isEffectivelyIgnored()); |
There was a problem hiding this comment.
Simplification suggested by IntelliJ.
ashleyfrieze
force-pushed
the
RunNotifierIssues
branch
from
01e139f
to
8f555fe
Compare
…ups not reported correctly
ashleyfrieze
force-pushed
the
RunNotifierIssues
branch
from
3332640
to
7dd4871
Compare
|
@ashleyfrieze looks great to me. If you confirmed that it gets the right IDE behavior, I'm ready to merge. 👍 Also has nice side effect, as you mentioned, of starting to isolate us incrementally away from the JUnit4 |
|
I'm pretty happy with this. Can you release it too? I feel bad that the general release has this howler in it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #110
Errors were reported in the wrong order confusing IDE JUnit runners