Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for beforeAll failures #112

Merged

Conversation

ashleyfrieze
Copy link
Contributor

Fixes for #110 and #109 further to #111 not quite fixing beforeAll.

Added additional tests and resolved a couple of minor glitches in docs and code for the JUnit rule support.

@codecov
Copy link

codecov bot commented Apr 23, 2017

Codecov Report

Merging #112 into master will decrease coverage by 0.13%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##             master    #112      +/-   ##
===========================================
- Coverage     99.43%   99.3%   -0.14%     
- Complexity      331     332       +1     
===========================================
  Files            40      40              
  Lines           714     717       +3     
  Branches         21      22       +1     
===========================================
+ Hits            710     712       +2     
- Partials          4       5       +1
Impacted Files Coverage Δ Complexity Δ
...kins/spectrum/dsl/specification/Specification.java 100% <100%> (ø) 19 <1> (ø) ⬇️
.../java/com/greghaskins/spectrum/internal/Suite.java 100% <100%> (ø) 53 <1> (ø) ⬇️
...eghaskins/spectrum/internal/junit/RuleContext.java 96.77% <100%> (+1.85%) 32 <8> (+3) ⬆️
...eghaskins/spectrum/internal/hooks/HookContext.java 100% <100%> (ø) 10 <0> (ø) ⬇️
.../spectrum/internal/junit/RunNotifierReporting.java 96.42% <0%> (-3.58%) 6% <0%> (-1%)
...com/greghaskins/spectrum/internal/hooks/Hooks.java 97.29% <0%> (-2.71%) 20% <0%> (-1%)

@codecov
Copy link

codecov bot commented Apr 23, 2017

Codecov Report

Merging #112 into master will increase coverage by 0.14%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master     #112      +/-   ##
============================================
+ Coverage     99.43%   99.58%   +0.14%     
- Complexity      331      334       +3     
============================================
  Files            40       40              
  Lines           714      717       +3     
  Branches         21       22       +1     
============================================
+ Hits            710      714       +4     
+ Partials          4        3       -1
Impacted Files Coverage Δ Complexity Δ
.../java/com/greghaskins/spectrum/internal/Suite.java 100% <100%> (ø) 53 <1> (ø) ⬇️
...eghaskins/spectrum/internal/junit/RuleContext.java 96.77% <100%> (+1.85%) 32 <8> (+3) ⬆️

@ashleyfrieze
Copy link
Contributor Author

Squashed the commit to make for a nicer merge... no pressure @greghaskins ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants