Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DatabasePool.setupMemoryManagement() #511

Merged
merged 1 commit into from
Apr 5, 2019
Merged

Fix DatabasePool.setupMemoryManagement() #511

merged 1 commit into from
Apr 5, 2019

Conversation

charlesmchen-signal
Copy link
Contributor

Due to a typo, DatabasePool erroneously observes the same notification type. I've fixed the typo.

  • This pull request is submitted against the development branch.

Per your comment on #510, I've opened this against GRDB-4.0.

  • Inline documentation has been updated.

Just fixing a typo; no docs need to be changed.

  • README.md or another dedicated guide has been updated.

Just fixing a typo; no docs need to be changed.

  • Changes are tested, for all flavors of GRDB, GRDBCipher, and GRDBCustomSQLite.

I haven't tested - the fix seems trivial?

@groue
Copy link
Owner

groue commented Apr 5, 2019

Well spotted 👍

@groue groue merged commit aeeb596 into groue:GRDB-4.0 Apr 5, 2019
@groue groue changed the title Fix notification name. Fix DatabasePool.setupMemoryManagement() Apr 5, 2019
@groue groue added this to the GRDB 4.0.0 milestone Apr 5, 2019
@groue groue added the bug label Apr 5, 2019
@groue groue mentioned this pull request Apr 5, 2019
Merged
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
GRDB 4.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@charlesmchen-signal @groue