GRDB 4.0 #479
Merged
GRDB 4.0 #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
This was referenced Mar 27, 2019
Closed
This was referenced Apr 10, 2019
Closed
Fixes previous test failure
Tests now fail
Adds a flag to SQLSelectQuery indicating that it expects a single record (for example when querying by primary or unique key).
Ensures that this example doesn't add an unnecessary LIMIT 1 to the resulting query:
let request = Player.filter(key: 123) // or Player.filter(key: ["email": "me@example.com"])
let player = try dbQueue.read { db in try request.fetchOne(db) }
This better hides this flag inside SQLSelectQuery, and avoids explicit support from FetchableRecord and TableRecord
We do not add LIMIT 1 to raw SQL requests because it is difficult. But it would not be wrong to do so.
We usually update all those tests together
Add "LIMIT 1" to `fetchOne` requests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The next major version GRDB 4 aims at supporting the Swift 5.0 compiler.
Support for SQLite Encryption Extension (SEE) #509 Support for SQLite Encryption Extension (SEE)Not readyfetchOnerequests #515 Add "LIMIT 1" tofetchOnerequestsLook at SE-0208 Package Manager System Library TargetsCan't use SE-0208 because the variadic sqlite3_config is not imported into Swift. We need a workaround.Look at SE-0236 Package Manager Platform Deployment SettingsNot untilswift-tools-version:5Look at SE-0238 Package Manager Target Specific Build SettingsNot untilswift-tools-version:5