Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for SQLCipher 4 #517

Merged
merged 33 commits into from
Apr 22, 2019
Merged

Support for SQLCipher 4 #517

merged 33 commits into from
Apr 22, 2019

Conversation

groue
Copy link
Owner

@groue groue commented Apr 19, 2019

This PR makes GRDB able to link with both SQLCipher 3 and 4, and will ship with GRDB 4 (#479).

  • The only supported way to use GRDB with SQLCipher is through CocoaPods. Other installation methods are no longer documented or supported.
  • The GRDBCipher CocoaPod is no longer, replaced with the GRDB.swift/SQLCipher subspec.

In a totally unrelated fashion, this PR also removes all former attempts at supporting Carthage (a long series of repeated failures and lack of commitment from everybody). Let's cut this dead branch.

  • Run and test GRDB with SQLCipher 4;
  • Test GRDB.swift/SQLCipher CocoaPod subspec.
  • Update documentation about installation of GRDB with SQLCipher support.
  • Write documentation about the transition to SQLCipher 4 (@Marus, @michaelkirk-signal, are you still interested in writing such a guide? Your help would be welcome).

@groue groue added this to the GRDB 4.0.0 milestone Apr 19, 2019
@groue groue mentioned this pull request Apr 19, 2019
26 tasks
@groue groue changed the title SQLCipher 4 Support for SQLCipher 4 Apr 21, 2019
@groue groue mentioned this pull request Apr 21, 2019
@groue groue merged commit bdbcf68 into GRDB-4.0 Apr 22, 2019
@groue groue deleted the SQLCipher-4 branch April 22, 2019 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant