feat: use StreamErrorHandler to send back invalid argument error in bidirectional streaming #4864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…idirectional streaming
johanbrandhorst
requested changes
Oct 23, 2024
ianbbqzy
force-pushed
the
stream-error-handler
branch
from
ea65295
to
2b48c69
Compare
ianbbqzy
force-pushed
the
stream-error-handler
branch
2 times, most recently
from
5bb2105
to
71053cc
Compare
ianbbqzy
force-pushed
the
stream-error-handler
branch
from
71053cc
to
7bd4ec4
Compare
johanbrandhorst
requested changes
Oct 24, 2024
ianbbqzy
force-pushed
the
stream-error-handler
branch
2 times, most recently
from
6599679
to
c05b3bc
Compare
ianbbqzy
force-pushed
the
stream-error-handler
branch
from
c05b3bc
to
1bf22c6
Compare
johanbrandhorst
approved these changes
Oct 24, 2024
|
Thanks for the contribution! |
|
Hey Johan, curious if there will be a release soon, or is it something that I have to initiate following the instructions in CONTRIBUTION.md? |
|
I'm planning a release soon, yeah, but there's another change in progress that I want to get in first: #4866 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References to other Issues or PRs
Fixes #4795
follow up to #4819
Have you read the Contributing Guidelines?
yes
Brief description of what is fixed or changed
Use StreamErrorHandler instead of ErrorHandler for sending back invalid request errors.
Other comments
taking inspiration from handleForwardResponseStreamError
can add some unit tests if looks good overall