fix: path parametrs of type number #4866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
path parameters generated with `expand_slashed_path_patterns` are of type `number`, should be a `string`
johanbrandhorst
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
path parameters generated with
expand_slashed_path_patternsare of typenumber, should be astringReferences to other Issues or PRs
Closes #4865
Relates #4784
Have you read the Contributing Guidelines?
Yes
Brief description of what is fixed or changed
All path parameters generated with
expand_slashed_path_patternshave a typestring.Other comments
I fixed that by explicitly setting the type of the newly generated parameter to
string. I tested that manually with my real API. I tried to write a test for this, but it turned out to be quite complicated