okhttp: Remove finished stream even if a pending stream was started

Fixes #11053
grpc · Mar 29, 2024 · 385ebda · 385ebda
1 parent 2c52450
commit 385ebda
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 1 deletion.
diff --git a/okhttp/src/main/java/io/grpc/okhttp/OkHttpClientTransport.java b/okhttp/src/main/java/io/grpc/okhttp/OkHttpClientTransport.java
@@ -953,8 +953,8 @@ void finishStream(
         }
         if (!startPendingStreams()) {
           stopIfNecessary();
-          maybeClearInUse(stream);
         }
+        maybeClearInUse(stream);
       }
     }
   }

diff --git a/okhttp/src/test/java/io/grpc/okhttp/OkHttpClientTransportTest.java b/okhttp/src/test/java/io/grpc/okhttp/OkHttpClientTransportTest.java
@@ -2080,6 +2080,26 @@ public void shutdownNow_streamListenerRpcProgress() throws Exception {
     assertEquals(MISCARRIED, listener3.rpcProgress);
   }
 
+  @Test
+  public void finishedStreamRemovedFromInUseState() throws Exception {
+    initTransport();
+    setMaxConcurrentStreams(1);
+    final MockStreamListener listener = new MockStreamListener();
+    OkHttpClientStream stream =
+        clientTransport.newStream(method, new Metadata(), CallOptions.DEFAULT, tracers);
+    stream.start(listener);
+    OkHttpClientStream pendingStream =
+        clientTransport.newStream(method, new Metadata(), CallOptions.DEFAULT, tracers);
+    pendingStream.start(listener);
+    waitForStreamPending(1);
+    clientTransport.finishStream(stream.transportState().id(), Status.OK, PROCESSED,
+        false, null, null);
+    verify(transportListener).transportInUse(true);
+    clientTransport.finishStream(pendingStream.transportState().id(), Status.OK, PROCESSED,
+        false, null, null);
+    verify(transportListener).transportInUse(false);
+  }
+
   private int activeStreamCount() {
     return clientTransport.getActiveStreams().length;
   }