Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OkHttp stream leak when hitting MAX_CONCURRENT_STREAMS #11053

Closed
hypnoce opened this issue Mar 28, 2024 · 0 comments · Fixed by #11054
Closed

OkHttp stream leak when hitting MAX_CONCURRENT_STREAMS #11053

hypnoce opened this issue Mar 28, 2024 · 0 comments · Fixed by #11054
Assignees
@ejona86
Labels
bug okhttp
Milestone
1.64

Comments

@hypnoce
Copy link
Contributor

hypnoce commented Mar 28, 2024

What version of gRPC-Java are you using?

1.60.0

What is your environment?

macOS Monterey, JDK 17

What did you expect to see?

I expect okhttp finished stream to be removed from the inUseState even if pending streams are being started

What did you see instead?

Removal of finished stream is conditional to the start or not of pending streams :

grpc-java/okhttp/src/main/java/io/grpc/okhttp/OkHttpClientTransport.java

Line 956 in 569b426

maybeClearInUse(stream);

Steps to reproduce the bug

2333097
hypnoce added a commit to hypnoce/grpc-java that referenced this issue Mar 28, 2024
@hypnoce
Fixes grpc#11053: make sure to remove finished stream in okhttp clien…
fd01fc3 
…t transport even if a pending stream was started.
@hypnoce hypnoce mentioned this issue Mar 28, 2024
Merged
hypnoce added a commit to hypnoce/grpc-java that referenced this issue Mar 28, 2024
@hypnoce
Fixes grpc#11053: make sure to remove finished stream in okhttp clien…
8c1b9e0 
…t transport even if a pending stream was started.
hypnoce added a commit to hypnoce/grpc-java that referenced this issue Mar 28, 2024
@hypnoce
Fixes grpc#11053: make sure to remove finished stream in okhttp clien…
41f2557 
…t transport even if a pending stream was started.
@ejona86 ejona86 changed the title OkHttp stream leak OkHttp stream leak when hitting MAX_CONCURRENT_STREAMS Mar 28, 2024
@ejona86 ejona86 added this to the 1.64 milestone Mar 28, 2024
@ejona86 ejona86 self-assigned this Mar 28, 2024
hypnoce added a commit to hypnoce/grpc-java that referenced this issue Mar 29, 2024
@hypnoce
Fixes grpc#11053: make sure to remove finished stream in okhttp clien…
19f970f 
…t transport even if a pending stream was started.
ejona86 pushed a commit that referenced this issue Mar 29, 2024
@hypnoce
okhttp: Remove finished stream even if a pending stream was started
d21fe32 
Fixes #11053
ejona86 pushed a commit to ejona86/grpc-java that referenced this issue Mar 29, 2024
@hypnoce @ejona86
okhttp: Remove finished stream even if a pending stream was started
f9d9b67 
Fixes grpc#11053
ejona86 pushed a commit to ejona86/grpc-java that referenced this issue Mar 29, 2024
@hypnoce @ejona86
okhttp: Remove finished stream even if a pending stream was started
6aa9788 
Fixes grpc#11053
This was referenced Mar 29, 2024
Merged
Merged
ejona86 pushed a commit that referenced this issue Mar 29, 2024
@hypnoce @ejona86
okhttp: Remove finished stream even if a pending stream was started
2249103 
Fixes #11053
ejona86 pushed a commit that referenced this issue Mar 29, 2024
@hypnoce @ejona86
okhttp: Remove finished stream even if a pending stream was started
385ebda 
Fixes #11053
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ejona86 ejona86

Labels
bug okhttp
Projects
None yet
Milestone
1.64
Development

Successfully merging a pull request may close this issue.

Fix OkHTTP client transport leak hypnoce/grpc-java
2 participants
@ejona86 @hypnoce