update reflection.proto from v1alpha to v1 #6724
Comments
|
There is no maven artifact that should be used instead. The proto was marked as "deprecated" in #4973, but AFAICT there has been no effort since then to move any of the tooling around v1alpha/reflection.proto to the "canonical" v1/reflection.proto. Reflection in C++, Java, or Go is all still using the v1alpha API, along with tooling like grpc_cli. Neither the gRPC core repo (https://github.com/grpc/grpc/blob/master/src/proto/grpc/reflection/v1alpha/reflection.proto) nor the gRPC Go repo (https://github.com/grpc/grpc-go/blob/master/reflection/grpc_reflection_v1alpha/reflection.proto) include the comment that the proto is "deprecated". Is this causing you some kind of issue? It certainly looks like something we need to internally clean up, but I would be interested to hear if this has impacted end users. |
|
The only problem it causes is deprecation warnings, which I can suppress until this is cleaned up. |
|
"The only problem it causes is deprecation warnings, which I can supress ..." Do you have a pointer on how deprecation warnings can be suppressed in Bazel? |
I currently don't use bazel, the comment was referring to a Scala build in SBT (using silencer to silence deprecation warnings) |
|
Hi, Is there any news regarding the support of reflection The file in grpc-go is now marked as deprecated even if the one in grpc-core is not. 🤔 |
Changes still in progress on the proto field mapping.
…rverServiceDefinition constructed from that of the v1 service but with the service and method names and proto descriptors modified. Issue grpc#6724. Squashed commit of the following: commit f1f2da7 Author: Kannan J <kannanjgithub@google.com> Date: Tue May 28 10:24:32 2024 +0000 Some nitty changes. commit 34f81e5 Author: Kannan J <kannanjgithub@google.com> Date: Tue May 28 10:09:49 2024 +0000 Create ProtoReflectionService for the v1alpha proto by producing a ServerServiceDefinition constructed from that of the v1 service but with the service and method names and proto descriptors modified. commit e99a8da Author: Kannan J <kannanjgithub@google.com> Date: Fri May 24 11:20:28 2024 +0000 Create V1 alpha service wrapping underlying V1 service, by modifying the ServerServiceDefinition. commit b2bb9e1 Author: Kannan J <kannanjgithub@google.com> Date: Fri May 24 07:14:42 2024 +0000 Changes to allow unit testing. commit a002bc2 Author: Kannan J <kannanjgithub@google.com> Date: Wed May 22 11:53:27 2024 +0000 Issue grpc#6724 to create a V1 reflection service. Changes still in progress on the proto field mapping.
V1 version of the proto reflection service, as the v1.alpha service has been deprecated. * Create V1 alpha service wrapping underlying V1 service, by modifying the ServerServiceDefinition. * Create ProtoReflectionService for the v1alpha proto by producing a ServerServiceDefinition constructed from that of the v1 service but with the service and method names and proto descriptors modified. Issue #6724.
V1 version of the proto reflection service, as the v1.alpha service has been deprecated. * Create V1 alpha service wrapping underlying V1 service, by modifying the ServerServiceDefinition. * Create ProtoReflectionService for the v1alpha proto by producing a ServerServiceDefinition constructed from that of the v1 service but with the service and method names and proto descriptors modified. Issue grpc#6724.
What version of gRPC-Java are you using?
1.27.1
What is your environment?
SBT
What did you expect to see?
grpc-services contains deprecated
v1alpha/reflection.protowhich instructs to usev1/reflection.proto, however the file is not shipped with this jar. It is unclear if there's a maven artifact that contains it that should be used instead.The text was updated successfully, but these errors were encountered: