netty: improve server handling of writes to reset streams #10258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A server stream can be reset by the client while server writes are still queued. After the stream is reset, the netty connection will forget the stream object. The `NettyServerHandler` must deal with that situation. `sendResponseHandlers` already had some code to do that. This change standardizes that code and adds it to `sendGrpcFrame`. This fixes a potential bug where a `SendGrpcFrameCommand` with `endOfStream=true` would raise an `AssertionError` if written to a reset stream. (This bug is not currently reachable because `endOfStream=false` for all server `SendGrpcFrameCommand` objects.)
ejona86
reviewed
Feb 15, 2024
There was a problem hiding this comment.
Looks like this slipped through the cracks. I'm sorry it didn't see movement earlier.
I'm definitely a fan of passing around Http2Stream instead of integers that then require lookups.
I made one comment. I don't mind making the change if you are no longer interested.
|
Looks like #10384 did something related. Although that change still assumes requireHttp2Stream succeeds. This seems even better. |
ejona86
added
the
kokoro:run
grpc-kokoro
removed
the
kokoro:run
benjaminp
force-pushed
the
improve-reset-handling
branch
3 times, most recently
from
d861527
to
58a6f83
Compare
benjaminp
force-pushed
the
improve-reset-handling
branch
from
58a6f83
to
151efeb
Compare
ejona86
approved these changes
Feb 16, 2024
|
@larry-safran, looks like the CI is broken due to a semantic merge conflict with the Multichild cleanup PR. |
ejona86
added
the
kokoro:run
grpc-kokoro
removed
the
kokoro:run
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A server stream can be reset by the client while server writes are still queued. After the stream is reset, the netty connection will forget the stream object. The
NettyServerHandlermust deal with that situation.sendResponseHandlersalready had some code to do that. This change standardizes that code and adds it tosendGrpcFrame. This fixes a potential bug where aSendGrpcFrameCommandwithendOfStream=truewould raise anAssertionErrorif written to a reset stream. (This bug is not currently reachable becauseendOfStream=falsefor all serverSendGrpcFrameCommandobjects.)