Fix retries that timeout hanging forever. #10855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larry-safran
requested review from
temawi and
sergiitk
and removed request for
temawi
sergiitk
reviewed
Jan 29, 2024
sergiitk
reviewed
Jan 29, 2024
There was a problem hiding this comment.
Is it possible to add a test to cover this case?
There was a problem hiding this comment.
Turns out that due to mocks it is difficult.
larry-safran
added
the
kokoro:force-run
grpc-kokoro
removed
kokoro:force-run
larry-safran
added
the
kokoro:force-run
grpc-kokoro
removed
the
kokoro:force-run
YifeiZhuang
reviewed
Jan 30, 2024
| boolean cancelled = retryFuture.cancel(false); | ||
| if (cancelled) { | ||
| inFlightSubStreams.decrementAndGet(); | ||
| } | ||
| } | ||
| if (hedgingFuture != null) { | ||
| hedgingFuture.cancel(false); |
There was a problem hiding this comment.
it looks hedging also has the same problem.
A UT would be really helpful in either retry or hedging cases.
sergiitk
approved these changes
Jan 30, 2024
larry-safran
force-pushed
the
retry_timeout
branch
from
50fbd32
to
3130739
Compare
larry-safran
added
the
TODO:backport
larry-safran
added a commit
to larry-safran/grpc-java
that referenced
this pull request
Feb 1, 2024
larry-safran
added a commit
to larry-safran/grpc-java
that referenced
this pull request
Feb 1, 2024
larry-safran
added a commit
to larry-safran/grpc-java
that referenced
this pull request
Feb 1, 2024
larry-safran
added a commit
to larry-safran/grpc-java
that referenced
this pull request
Feb 1, 2024
larry-safran
added a commit
to larry-safran/grpc-java
that referenced
this pull request
Feb 1, 2024
larry-safran
added a commit
to larry-safran/grpc-java
that referenced
this pull request
Feb 1, 2024
larry-safran
added a commit
to larry-safran/grpc-java
that referenced
this pull request
Feb 1, 2024
larry-safran
added a commit
to larry-safran/grpc-java
that referenced
this pull request
Feb 1, 2024
larry-safran
added a commit
to larry-safran/grpc-java
that referenced
this pull request
Feb 1, 2024
larry-safran
added a commit
to larry-safran/grpc-java
that referenced
this pull request
Feb 1, 2024
This was referenced Feb 1, 2024
This was referenced Feb 1, 2024
larry-safran
added a commit
that referenced
this pull request
Feb 6, 2024
larry-safran
added a commit
that referenced
this pull request
Feb 6, 2024
larry-safran
added a commit
to larry-safran/grpc-java
that referenced
this pull request
Feb 7, 2024
…#10884) * Fix retries that timeout hanging forever. (grpc#10855) Fixes grpc#10336
larry-safran
added a commit
that referenced
this pull request
Feb 7, 2024
This reverts commit c0a9d31.
larry-safran
added a commit
that referenced
this pull request
Feb 7, 2024
larry-safran
removed
the
TODO:backport
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10336
Thanks to @turchenkoalex for identifying the underlying problem and fix.