-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix retries that timeout hanging forever. [ Backport to 1.59.x] #10884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
temawi
approved these changes
Feb 1, 2024
* Reorder tracing and actually closing listener to eliminate test flakiness * Use real value rather than mock for flaky test
…red command is run.
…fter clock is moved forward.
larry-safran
added a commit
to larry-safran/grpc-java
that referenced
this pull request
Feb 7, 2024
…#10884) * Fix retries that timeout hanging forever. (grpc#10855) Fixes grpc#10336
hi, this fix was reverted later, is a related fix available in the latest versions? |
Sorry, not yet - we still need to work on this. Are you being impacted by this? |
yes, we try to be on the latest grpc version but since this is broken we have reverted it back to 1.51.0 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #10855