Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix retries that timeout hanging forever. [ Backport to 1.59.x] #10884

Merged
merged 8 commits into from
Feb 6, 2024

Conversation

larry-safran
Copy link
Contributor

Backport #10855

* Reorder tracing and actually closing listener to eliminate test flakiness
* Use real value rather than mock for flaky test
@larry-safran larry-safran added the kokoro:force-run Add this label to a PR to tell Kokoro to re-run all tests. Not generally necessary label Feb 6, 2024
@grpc-kokoro grpc-kokoro removed the kokoro:force-run Add this label to a PR to tell Kokoro to re-run all tests. Not generally necessary label Feb 6, 2024
@larry-safran larry-safran merged commit b05c9f7 into grpc:v1.59.x Feb 6, 2024
14 checks passed
@larry-safran larry-safran deleted the backport--1.59 branch February 6, 2024 22:07
larry-safran added a commit to larry-safran/grpc-java that referenced this pull request Feb 7, 2024
@fairooz18
Copy link

hi, this fix was reverted later, is a related fix available in the latest versions?

@temawi
Copy link
Contributor

temawi commented Mar 15, 2024

hi, this fix was reverted later, is a related fix available in the latest versions?

Sorry, not yet - we still need to work on this. Are you being impacted by this?

@fairooz18
Copy link

yes, we try to be on the latest grpc version but since this is broken we have reverted it back to 1.51.0
Is there any plan on fixing this anytime soon?

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants