-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
opentelemetry: Add explicit histogram buckets for per-call metrics #11281
Merged
DNVindhya
merged 4 commits into
grpc:master
from
DNVindhya:opentelemetry-explicit-bucket-boundary
Jun 12, 2024
Merged
opentelemetry: Add explicit histogram buckets for per-call metrics #11281
DNVindhya
merged 4 commits into
grpc:master
from
DNVindhya:opentelemetry-explicit-bucket-boundary
Jun 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejona86
approved these changes
Jun 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably will want to only test hasBucketCounts()
once for each metric, but this is fine for now.
ejona86
added a commit
to ejona86/grpc-java
that referenced
this pull request
Jun 12, 2024
It is simultaneously overly zealous and doesn't notice basic cases. As noticed in grpc#11281.
ejona86
added a commit
to ejona86/grpc-java
that referenced
this pull request
Jun 12, 2024
It is simultaneously overly zealous and doesn't notice basic cases. As noticed in grpc#11281.
ejona86
added a commit
that referenced
this pull request
Jun 12, 2024
It is simultaneously overly zealous and doesn't notice basic cases. As noticed in #11281.
DNVindhya
added a commit
to DNVindhya/grpc-java
that referenced
this pull request
Jun 13, 2024
…rpc#11281) Add explicit histogram buckets for per-call metrics as specified in gRFC A66 https://github.com/grpc/proposal/blob/master/A66-otel-stats.md#units.
DNVindhya
pushed a commit
to DNVindhya/grpc-java
that referenced
this pull request
Jun 13, 2024
It is simultaneously overly zealous and doesn't notice basic cases. As noticed in grpc#11281.
DNVindhya
added a commit
that referenced
this pull request
Jun 13, 2024
DNVindhya
added a commit
to DNVindhya/grpc-java
that referenced
this pull request
Jun 14, 2024
…rpc#11281) Add explicit histogram buckets for per-call metrics as specified in gRFC A66 https://github.com/grpc/proposal/blob/master/A66-otel-stats.md#units.
DNVindhya
added a commit
that referenced
this pull request
Jun 14, 2024
…11281) (#11287) Add explicit histogram buckets for per-call metrics as specified in gRFC A66 https://github.com/grpc/proposal/blob/master/A66-otel-stats.md#units.
larry-safran
pushed a commit
to larry-safran/grpc-java
that referenced
this pull request
Aug 13, 2024
It is simultaneously overly zealous and doesn't notice basic cases. As noticed in grpc#11281.
larry-safran
pushed a commit
to larry-safran/grpc-java
that referenced
this pull request
Aug 13, 2024
…rpc#11281) Add explicit histogram buckets for per-call metrics as specified in gRFC A66 https://github.com/grpc/proposal/blob/master/A66-otel-stats.md#units.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of gRFC A66:
This PR adds histogram bucket boundaries for per-call metrics.
CC @yashykt