Disable ErrorProne's MutableConstantField check #11283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is simultaneously overly zealous and doesn't notice basic cases. As noticed in grpc#11281.
DNVindhya
approved these changes
Jun 12, 2024
DNVindhya
added a commit
to DNVindhya/grpc-java
that referenced
this pull request
Jun 12, 2024
DNVindhya
added
the
TODO:backport
DNVindhya
pushed a commit
to DNVindhya/grpc-java
that referenced
this pull request
Jun 13, 2024
It is simultaneously overly zealous and doesn't notice basic cases. As noticed in grpc#11281.
DNVindhya
added a commit
that referenced
this pull request
Jun 13, 2024
DNVindhya
removed
the
TODO:backport
larry-safran
pushed a commit
to larry-safran/grpc-java
that referenced
this pull request
Aug 13, 2024
It is simultaneously overly zealous and doesn't notice basic cases. As noticed in grpc#11281.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is simultaneously overly zealous and doesn't notice basic cases. As noticed in #11281.