Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add server examples - fixes #317 #319

Merged
merged 5 commits into from
Feb 17, 2022
Merged

add server examples - fixes #317 #319

merged 5 commits into from
Feb 17, 2022

Conversation

jamesward
Copy link
Collaborator

No description provided.

@jamesward jamesward requested a review from bshaffer February 8, 2022 18:32
Kernald added a commit to Kernald/grpc-kotlin that referenced this pull request Feb 14, 2022
Bazelisk currently automatically picks the latest Bazel release in CI.
This broke since Bazel 5 has been released a few weeks ago (the main
culprit being an out-of-date grpc-java). While ultimately we'd want to
fix the issue (which grpc#319 seems to do), fixing Bazel's version moving
forward is likely a good thing to prevent this kind of unrelated
breakages and ensuring reproducible builds.
@Kernald Kernald mentioned this pull request Feb 14, 2022
jamesward pushed a commit that referenced this pull request Feb 15, 2022
Bazelisk currently automatically picks the latest Bazel release in CI.
This broke since Bazel 5 has been released a few weeks ago (the main
culprit being an out-of-date grpc-java). While ultimately we'd want to
fix the issue (which #319 seems to do), fixing Bazel's version moving
forward is likely a good thing to prevent this kind of unrelated
breakages and ensuring reproducible builds.
@jamesward jamesward force-pushed the example-tests branch 3 times, most recently from 9f94fa0 to 240934f Compare February 15, 2022 21:10
Copy link
Contributor

@bshaffer bshaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed tests are running and passing in Github Actions for Java 11

jamesward and others added 4 commits February 17, 2022 07:54
…uteGuideServerTest.kt

Co-authored-by: Brent Shaffer <betterbrent@google.com>
…lloWorldServerTest.kt

Co-authored-by: Brent Shaffer <betterbrent@google.com>
…lsServerTest.kt

Co-authored-by: Brent Shaffer <betterbrent@google.com>
@jamesward jamesward merged commit c7b29c0 into master Feb 17, 2022
@jamesward jamesward deleted the example-tests branch February 17, 2022 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants