-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add server examples - fixes #317 #319
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesward
force-pushed
the
example-tests
branch
from
February 9, 2022 20:04
fb335fb
to
f7dcee7
Compare
Kernald
added a commit
to Kernald/grpc-kotlin
that referenced
this pull request
Feb 14, 2022
Bazelisk currently automatically picks the latest Bazel release in CI. This broke since Bazel 5 has been released a few weeks ago (the main culprit being an out-of-date grpc-java). While ultimately we'd want to fix the issue (which grpc#319 seems to do), fixing Bazel's version moving forward is likely a good thing to prevent this kind of unrelated breakages and ensuring reproducible builds.
Merged
jamesward
pushed a commit
that referenced
this pull request
Feb 15, 2022
Bazelisk currently automatically picks the latest Bazel release in CI. This broke since Bazel 5 has been released a few weeks ago (the main culprit being an out-of-date grpc-java). While ultimately we'd want to fix the issue (which #319 seems to do), fixing Bazel's version moving forward is likely a good thing to prevent this kind of unrelated breakages and ensuring reproducible builds.
jamesward
force-pushed
the
example-tests
branch
3 times, most recently
from
February 15, 2022 21:10
9f94fa0
to
240934f
Compare
jamesward
force-pushed
the
example-tests
branch
from
February 16, 2022 21:09
240934f
to
33fe5aa
Compare
bshaffer
approved these changes
Feb 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed tests are running and passing in Github Actions for Java 11
examples/server/src/test/kotlin/io/grpc/examples/routeguide/RouteGuideServerTest.kt
Outdated
Show resolved
Hide resolved
examples/server/src/test/kotlin/io/grpc/examples/helloworld/HelloWorldServerTest.kt
Outdated
Show resolved
Hide resolved
examples/server/src/test/kotlin/io/grpc/examples/animals/AnimalsServerTest.kt
Outdated
Show resolved
Hide resolved
…uteGuideServerTest.kt Co-authored-by: Brent Shaffer <betterbrent@google.com>
…lloWorldServerTest.kt Co-authored-by: Brent Shaffer <betterbrent@google.com>
…lsServerTest.kt Co-authored-by: Brent Shaffer <betterbrent@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.