Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use proper Maven targets rather than legacy compat ones #321

Merged
merged 2 commits into from
Feb 15, 2022

Conversation

Kernald
Copy link
Contributor

@Kernald Kernald commented Feb 14, 2022

Using legacy targets forces downstream users to enable compat repositories as well.

Using legacy targets forces downstream users to enable compat
repositories as well.
@jamesward
Copy link
Collaborator

jamesward commented Feb 14, 2022

The Bazel tests are failing with the same issues I ran into & fixed in #319. If you rebase this on #319, that'd be awesome. Otherwise, you can copy & paste / cherry-pick any of my changes and then I'll rebase on yours. :)

@Kernald
Copy link
Contributor Author

Kernald commented Feb 14, 2022

I was actually about to submit another PR fixing Bazel version to 4.2.2. While updating grpc-java is the proper solution, fixing the version we use (for now to 4.2.2, or to 5.0. once #319 is merged) is probably a good thing moving forward anyway :-)

@Kernald
Copy link
Contributor Author

Kernald commented Feb 14, 2022

#322 is adding a .bazelversion, I'm happy to update it to 5.0.0 and wait for #319 to be merged.

@jamesward jamesward self-requested a review February 15, 2022 16:35
@jamesward jamesward merged commit b233a2e into grpc:master Feb 15, 2022
@jamesward
Copy link
Collaborator

Thank you!

@Kernald Kernald deleted the maven-compat branch February 15, 2022 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants