Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grpc-js: Loosen requirements on channel option types #1916

Merged
merged 1 commit into from
Sep 27, 2021
Merged

grpc-js: Loosen requirements on channel option types #1916

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 2 additions & 12 deletions packages/grpc-js/src/channel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,18 +177,8 @@ export class ChannelImplementation implements Channel {
);
}
if (options) {
if (
typeof options !== 'object' ||
!Object.values(options).every(
(value) =>
typeof value === 'string' ||
typeof value === 'number' ||
typeof value === 'undefined'
)
) {
throw new TypeError(
'Channel options must be an object with string or number values'
);
if (typeof options !== 'object') {
throw new TypeError('Channel options must be an object');
}
}
const originalTargetUri = parseUri(target);
Expand Down