-
Notifications
You must be signed in to change notification settings - Fork 767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If an empty .proto
is specified to closure_grpc_web_library()
it will fail.
#1076
Comments
An interesting indirectly related conversation about this topic on the python protoc generator. |
Here is the problem area of the code. Each source file gets |
This adds a `ctx.actions.write` to each of the automatically generated source targets that have been declared. This prevents an issue if the source targets do not yield a `.grpc.js` generated file because they do not contain an `rpc` definition (e.g. proto files that only contain a `message`). Resolves: grpc#1076
Hi :) Closing due to being obsolescence — |
It looks like the
closure_grpc_web_library()
bazel rule might not quite handle empty proto files correctly.I have created a mostly empty
.proto
file like so:order.proto
BUILD.bazel
When I run this, I get the following output:
I think this is because
protoc
does not create output for these blank files, but the bazel rule still declares them as a target. A simple solution might be totouch
the files to create empty placeholders before runningprotoc
.The text was updated successfully, but these errors were encountered: