Generate empty files in closure_grpc_web_library() bazel rules #1085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a `ctx.actions.write` to each of the automatically generated source targets that have been declared. This prevents an issue if the source targets do not yield a `.grpc.js` generated file because they do not contain an `rpc` definition (e.g. proto files that only contain a `message`). Resolves: grpc#1076
psigen
changed the title
psigen
changed the title
|
@stanley-cheung this version passed all the tests locally. |
|
Thanks a lot for the PR! But unfortunately, we've decided to clean up our Bazel + javascript uses in #1138.. So this change no longer applies.. Sorry for the change! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a flag
allow_empty_fileswhich forces the generation of output.grpc.jsfiles even if they do not contain service definitions. The flag isFalseby default, to retain the current behavior. It is setTruein the bazel plugin, and should be set when using any build system that tracks generated output files.This prevents an issue if the source targets do not yield a
.grpc.jsgenerated file because they do not contain anrpcdefinition (e.g. proto files that only contain amessage).Resolves: #1076
Supersedes: #1077