Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRAN Errors to fix by 2023-03-22 #256

Closed
zkamvar opened this issue Mar 8, 2023 · 2 comments
Closed

CRAN Errors to fix by 2023-03-22 #256

zkamvar opened this issue Mar 8, 2023 · 2 comments

Comments

@zkamvar
Copy link
Member

zkamvar commented Mar 8, 2023

Dear maintainer,

Please see the problems shown on
https://cran.r-project.org/web/checks/check_results_poppr.html.

Please correct before 2023-03-22 to safely retain your package on CRAN.

Best,
-k


Version: 2.9.3
Check: whether package can be installed
Result: WARN
Found the following significant warnings:
init.c:24:21: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
omp_test.c:7:14: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
See ‘/home/hornik/tmp/R.check/r-devel-clang/Work/PKGS/poppr.Rcheck/00install.out’ for details.
* used C compiler: ‘Debian clang version 15.0.6’
Flavor: r-devel-linux-x86_64-debian-clang

Version: 2.9.3
Check: Rd files
Result: NOTE
checkRd: (-1) genetic_distance.Rd:106: Escaped LaTeX specials: ~
Flavors: r-devel-linux-x86_64-debian-clang, r-devel-linux-x86_64-debian-gcc, r-devel-linux-x86_64-fedora-clang, r-devel-linux-x86_64-fedora-gcc

Version: 2.9.3
Check: tests
Result: ERROR

 Running ‘test-all.R’ [19s/23s]
Running the tests in ‘tests/test-all.R’ failed.
Complete output:
 > library(testthat)
 > options(poppr.debug = TRUE)
 > test_check("poppr")
 Loading required package: poppr
 Loading required package: adegenet
 Loading required package: ade4

 /// adegenet 2.1.10 is loaded ////////////

 > overview: '?adegenet'
 > tutorials/doc/questions: 'adegenetWeb()'
 > bug reports/feature requests: adegenetIssues()


 This is poppr version 2.9.3. To get started, type package?poppr
 OMP parallel support: available
 [ FAIL 2 | WARN 0 | SKIP 181 | PASS 378 ]

 ══ Skipped tests ═══════════════════════════════════════════════════════════════
 • On CRAN (181)

 ══ Failed tests ════════════════════════════════════════════════════════════════
 ── Failure ('test-msn.R:438'): nodes are properly scaled ───────────────────────
 sort(...) not equal to sort(...).
 Attributes: < Modes: list, NULL >
 Attributes: < Lengths: 2, 0 >
 Attributes: < names for target but not for current >
 Attributes: < current is not list-like >
 target is table, current is numeric
 Backtrace:
 ▆
 1. └─poppr (local) expect_vertex_size_scale(bmsn, as.integer(table(mll(pc)))) at test-msn.R:438:2
 2. ├─base::eval(...) at test-msn.R:105:2
 3. │ └─base::eval(...)
 4. └─testthat::expect_equal(...)
 ── Failure ('test-msn.R:439'): nodes are properly scaled ───────────────────────
 sort(...) not equal to sort(...).
 Attributes: < Modes: list, NULL >
 Attributes: < Lengths: 2, 0 >
 Attributes: < names for target but not for current >
 Attributes: < current is not list-like >
 target is table, current is numeric
 Backtrace:
 ▆
 1. └─poppr (local) expect_vertex_size_scale(pmsn, as.integer(table(mll(pc)))) at test-msn.R:439:2
 2. ├─base::eval(...) at test-msn.R:105:2
 3. │ └─base::eval(...)
 4. └─testthat::expect_equal(...)

 [ FAIL 2 | WARN 0 | SKIP 181 | PASS 378 ]
 Error: Test failures
 Execution halted
@zkamvar zkamvar self-assigned this Mar 8, 2023
zkamvar added a commit that referenced this issue Mar 21, 2023
zkamvar added a commit that referenced this issue Mar 21, 2023
I am removing a test that is failing because the behaviour of
expect_equal or the behavior of igraph has changed and I do not wish to
spend so much time trying to figure out what is misbehaving.

This test was testing that the size of the nodes were expected to be the
square of the number of members.

This will address #256
@zkamvar
Copy link
Member Author

zkamvar commented Mar 21, 2023

apparently 85209b3 did not actually do anything -_-

zkamvar added a commit that referenced this issue Mar 21, 2023
This will address #256
@zkamvar
Copy link
Member Author

zkamvar commented Mar 25, 2023

fixed by #257

@zkamvar zkamvar closed this as completed Mar 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant