Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cran bug 256 #257

Merged
merged 24 commits into from
Mar 25, 2023
Merged

Fix cran bug 256 #257

merged 24 commits into from
Mar 25, 2023

Conversation

zkamvar
Copy link
Member

@zkamvar zkamvar commented Mar 21, 2023

No description provided.

I am removing a test that is failing because the behaviour of
expect_equal or the behavior of igraph has changed and I do not wish to
spend so much time trying to figure out what is misbehaving.

This test was testing that the size of the nodes were expected to be the
square of the number of members.

This will address #256
diversity_ci is now rendering properly
This will address #256
I'm doing this, not because it is the correct thing to do, but because I
do not want to have to figure out what the hell CRAN is complaining
about for a citation that has existed on CRAN for several years.

It sucks because ñ is NOT the same as n, but unfortunately, CRAN
complains when we include non-ASCII characters in our code.
@zkamvar
Copy link
Member Author

zkamvar commented Mar 25, 2023

It has been released to cran

@zkamvar zkamvar merged commit ee9c908 into main Mar 25, 2023
@zkamvar zkamvar deleted the fix-cran-bug-256 branch March 25, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant