-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Forward Proxy Authentication #48
Conversation
Btw, thanks a lot for the patches, they are going in the right direction, mostly :) |
Thanks a lot! |
82d74e9
to
25be8ec
Compare
This lets browsers to fall back to basic auth if supported (similar to 4e7967e). Add boolean param to is_mech_allowed which denotes whether the caller supports multiple step.
…tion Make sure each request is authenticated according to given credentials even when GssapiConnectionBound is set.
Proxy auth headers are a little different. Sessions cannot be used as we cannot set a cookie.
Add test for second user on the same connection with the password of the first user and without auth at all.
Idealy we could use Python 'requests' but I don't seem to find how to make it work. Also it would have been better to do server-auth using SPNEGO but curl loops re-using the same authz blob which gets rejected by MAG (Request is a replay). This seem resolved in recent versions but for now let the test do SPNEGO for Proxy auth only.
Hi Simo, I updated the commits based on your suggestions (sorry for the little git mess). Hope I didn't take the 'init_cfg' too far :) Regards, |
I correct a few typos, and changed the condition of the first patch as mc != NULL is necessary but not sufficient for NTLM, you need cfg->gss_conn_ctx to have a successful NTLM auth for now. |
The Authorization headers are initially added (generated by gssapi module). As discussed at gssapi#48 Thanks, Isaac B.
The Authorization headers are initially added (generated by gssapi module). As discussed at gssapi#48 Thanks, Isaac B.
Add appropairate authorization headers to test with SPNEGO too as discussed in #48 Requires recent version of python-gssapi module, see: pythongssapi/python-gssapi#74 Simo: Squashed original patches in one, removed trailing whitespaces and reworded the commit message. Reviewed-by: Simo Sorce <simo@redhat.com> Closes #49
Along with some other commits.
Cheers,
Isaac B.