Support Forward Proxy Authentication #48
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Btw, thanks a lot for the patches, they are going in the right direction, mostly :) |
|
Thanks a lot! |
iboukris
force-pushed
the
test_suit
branch
2 times, most recently
from
82d74e9
to
25be8ec
Compare
This lets browsers to fall back to basic auth if supported (similar to 4e7967e). Add boolean param to is_mech_allowed which denotes whether the caller supports multiple step.
…tion Make sure each request is authenticated according to given credentials even when GssapiConnectionBound is set.
Proxy auth headers are a little different. Sessions cannot be used as we cannot set a cookie.
Add test for second user on the same connection with the password of the first user and without auth at all.
Idealy we could use Python 'requests' but I don't seem to find how to make it work. Also it would have been better to do server-auth using SPNEGO but curl loops re-using the same authz blob which gets rejected by MAG (Request is a replay). This seem resolved in recent versions but for now let the test do SPNEGO for Proxy auth only.
|
Hi Simo, I updated the commits based on your suggestions (sorry for the little git mess). Hope I didn't take the 'init_cfg' too far :) Regards, |
|
I correct a few typos, and changed the condition of the first patch as mc != NULL is necessary but not sufficient for NTLM, you need cfg->gss_conn_ctx to have a successful NTLM auth for now. |
iboukris
added a commit
to iboukris/mod_auth_gssapi
that referenced
this pull request
Aug 9, 2015
The Authorization headers are initially added (generated by gssapi module). As discussed at gssapi#48 Thanks, Isaac B.
iboukris
added a commit
to iboukris/mod_auth_gssapi
that referenced
this pull request
Aug 9, 2015
The Authorization headers are initially added (generated by gssapi module). As discussed at gssapi#48 Thanks, Isaac B.
simo5
pushed a commit
that referenced
this pull request
Sep 3, 2015
Add appropairate authorization headers to test with SPNEGO too as discussed in #48 Requires recent version of python-gssapi module, see: pythongssapi/python-gssapi#74 Simo: Squashed original patches in one, removed trailing whitespaces and reworded the commit message. Reviewed-by: Simo Sorce <simo@redhat.com> Closes #49
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Along with some other commits.
Cheers,
Isaac B.