Fix SPNEGO crash #74
Fix SPNEGO crash #74
Conversation
The actual_mech is not promised till we complet the context. This fix a segfault when creating a SecurityContext with SPNEGO mech.
Seem trivial, silents compiler warning: warning: gssapi/raw/sec_contexts.pyx:367:8: Unreachable code
|
Thanks! |
| @@ -204,7 +204,7 @@ flags=None, lifetime=None, channel_bindings=None, input_token=None) | |||
| input_token_buffer.value = input_token | |||
| input_token_buffer.length = len(input_token) | |||
|
|
|||
| cdef gss_OID actual_mech_type | |||
| cdef gss_OID actual_mech_type = GSS_C_NO_OID; | |||
There was a problem hiding this comment.
please remove the ; from the end of this line
|
a couple of nits inline. Travis had a moment before, but it looks like you're just failing due to flake8 not liking the |
|
Hi Solly and Simo, On Mon, Aug 10, 2015 at 11:00 PM, Solly notifications@github.com wrote:
Thanks, I'll fix and add a commit. One more thing, what do you think - do we want to raise an error if the Regards, |
|
Isaac Boukris notifications@github.com writes:
I think we want to follow the behavior of the library, since it's either |
|
On Mon, Aug 10, 2015 at 11:36 PM, Robbie Harwood notifications@github.com
Make sense - thanks. |
Add appropairate authorization headers to test with SPNEGO too as discussed in #48 Requires recent version of python-gssapi module, see: pythongssapi/python-gssapi#74 Simo: Squashed original patches in one, removed trailing whitespaces and reworded the commit message. Reviewed-by: Simo Sorce <simo@redhat.com> Closes #49
Hello,
This fix a segfault when trying to init_sec_context with SPNEGO mechanism.
Issue was found at (see there for an example to reproduce):
https://github.com/modauthgssapi/mod_auth_gssapi/pull/49
Thanks!