Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace once_cell crate with std::sync::OnceLock #1532

Merged
merged 2 commits into from
Jan 27, 2024
Merged

Replace once_cell crate with std::sync::OnceLock #1532

merged 2 commits into from
Jan 27, 2024

Conversation

andy128k
Copy link
Contributor

@andy128k andy128k commented Jan 21, 2024 •
edited
Loading

@andy128k
Copy link
Contributor Author

Tests fail but when I checkout a version of gir-files before this PR then they pass.

@andy128k andy128k marked this pull request as ready for review January 21, 2024 18:10
@andy128k andy128k mentioned this pull request Jan 21, 2024
Merged
@andy128k andy128k marked this pull request as draft January 22, 2024 09:25
@bilelmoussaoui
Copy link
Member

Tests fail but when I checkout a version of gir-files before this PR then they pass.

Should be fixed now

@andy128k
Copy link
Contributor Author

Nope :( still fails

@bilelmoussaoui
Copy link
Member

Nope :( still fails

If you rebase, it should

@sdroege sdroege marked this pull request as ready for review January 27, 2024 07:51
@sdroege sdroege merged commit 8d78966 into gtk-rs:master Jan 27, 2024
7 checks passed
@andy128k andy128k deleted the std_cells branch January 27, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdroege sdroege sdroege approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andy128k @bilelmoussaoui @sdroege