This repository has been archived by the owner on Mar 4, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 88
Remove get for getters & properties where applicable #211
Merged
GuillaumeGomez
merged 5 commits into
gtk-rs:master
from
fengalin:remove-get_-for-getters
Apr 13, 2021
Merged
Remove get for getters & properties where applicable #211
GuillaumeGomez
merged 5 commits into
gtk-rs:master
from
fengalin:remove-get_-for-getters
Apr 13, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Requires some manual changes I didn't catch yet... |
Thought I should clarify: this is WIP in the sense that it can't be merged as is because:
Other than that, it's ready :) |
fengalin
changed the title
WIP: remove get for getters & properties where applicable
Remove get for getters & properties where applicable
Jan 16, 2021
sdroege
reviewed
Apr 10, 2021
sdroege
reviewed
Apr 10, 2021
sdroege
reviewed
Apr 10, 2021
sdroege
reviewed
Apr 10, 2021
sdroege
reviewed
Apr 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks all good to me otherwise. Thanks :)
Fixes a couple of getters that wouldn't play well with the getter auto-renaming rules.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note to application developers
Applications developers should use
fix-getters-calls
to ease migration of their applications. If you also wish to change your get functions definition to comply with the standards implemented here, usefix-getters-def
.Object
This is an attempt at fixing gtk-rs/gir#963.
Dependencies
fix-getters
.The last repository is a pair of tools to automate manual code getters definitions and call sites update. Please take a look at the
README
s in this repo. They explain the assumptions and decisions I had to make to achieve this. Of course, these assumption are all subject to debate. The repository also provides a crate which implements getter renaming rules. See the discussion in the gir PR.Content
This PR consists in the following commits with different reviewing needs:
gir
is updated in this commit. Nothing special here, discussion should occur in this PR.regen
produces many changes in this commit, but those changes result from automatic rules. I did several iterations at the changes and at the functions which were kept unchanged, but it's most possible that I overlooked something. I think agreeing on the rules explained infix-getters-rules
and the changes togir
should cover most of the concerns though.fix-getters
tools in this commit. If we agree on what is described in theREADME
s, I think we should be covered for this.Base + a request
This is based on a snapshot of master and I will keep this as a basis until we reach the decision to merge this because it's quite time consuming to update. If / when we decide to merge, I would like that no branch be merged in neither
gir
norgtk-rs
until we get this merged completely.I'll update
gstreamer-rs
when we come close to a merge decision.