Remove get for getters & properties where applicable #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengalin
force-pushed
the
remove-get_-for-getters
branch
from
38cc0b5 to
4c0acc2
Compare
| @@ -80,7 +80,7 @@ impl WidgetImpl for CustomButton {} | |||
| // Trait shared by all buttons | |||
| impl ButtonImpl for CustomButton { | |||
| fn clicked(&self, button: &Self::Type) { | |||
| let incremented_number = self.number.borrow().clone() + 1; | |||
| let incremented_number = *self.number.borrow() + 1; | |||
There was a problem hiding this comment.
Interesting, we should run clippy for the book listings as well
cc @Hofer-Julian
There was a problem hiding this comment.
Good idea!
Do you want to open a PR or issue for that?
fengalin
commented
Apr 13, 2021
fengalin
force-pushed
the
remove-get_-for-getters
branch
from
4c0acc2 to
c7b5bdd
Compare
|
Will force push again shortly, just noticed that Edit: done. |
fengalin
force-pushed
the
remove-get_-for-getters
branch
from
c7b5bdd to
181376c
Compare
fengalin
force-pushed
the
remove-get_-for-getters
branch
from
181376c to
096fc4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note to application developers
Applications developers should use
fix-getters-callsto ease migration of their applications. If you also wish to change your get functions definition to comply with the standards implemented here, usefix-getters-def.Object
This is the continuation of gtk-rs/gir#1021 and gtk-rs/gtk3-rs#211 as an attempt to address gtk-rs/gir#963.
This one uses the
fix-getterstools, which should ease migration for applications developers. Note however, that some moregetfunctions might be renamed due to the conservative approach of these tools.I used the same conflict resolutions that I used for
gtk-rswhere applicable. Please take a look at the first commit ("gir prerp. for regen..."). If we decide to change some of these conflict resolutions, I'll updategtk-rstoo.@bilelmoussaoui: with @sdroege, we planned to perform a second pass on
gtk-rs,gtk4-rsandgstreamer-rsto address a couple of edge cases related toenumgeneration and subclassing (similar to the discussion we had in your PR). See https://gitlab.freedesktop.org/gstreamer/gstreamer-rs/-/issues/325. The idea is to get the big chunk in shortly and proceed with these details in the coming days.