Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

livereload.js fails due to case-sensitive REL attribute condition #118

Closed
nemoDreamer opened this issue Sep 22, 2014 · 1 comment
Closed

Comments

@nemoDreamer
Copy link
Contributor

I'm using guard-livereload on a legacy Rails project running the asset_packager helper (before Rails had this built-in). It took me forever to figure out that livereload.js was checking for linked stylesheets using xxx.rel === 'stylesheet', which failed to trigger because the old asset packager was writing its tags using rel = "Stylesheet"...

I've fixed this in a feature branch, and will submit a pull request shortly.

On a side-note:
why are you logging only if this.window.location.href.match(/LR-verbose/)? I would have caught this uch sooner if the script were simply dumping in the user's console at any time. I guess you don't want to spam?

nemoDreamer added a commit to nemoDreamer/guard-livereload that referenced this issue Sep 22, 2014
@nemoDreamer
Copy link
Contributor Author

Closed by pull-request #119

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant