-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prevent rspec_guard_result
#247
Comments
It's currently used for notification and failed_mode purpose and there's no way of avoid it yet. Maybe we could use chdir as well to prevent your issue. @907th what do you think? |
@thibaudgg I think it is sufficient to use absolute path to temporary file (we're using relative one now). |
👍 |
👍 No more duplicate logs being created throughout the project. |
I just noticed that the spec updates throw a warning now...
|
@brewster1134 It's strange, I'll check it later. |
Actually looking at the output closer... its because both ver. 4.2.4 AND your branch are being loaded. I am just pointing to your branch through bundler. strange.. gem 'guard-rspec', github: '907th/guard-rspec' .../guard-rspec-6e1852c87fb9/lib/guard/rspec/formatter.rb:7: warning: already initialized constant Guard::RSpec::Formatter::TEMPORARY_FILE_PATH
.../guard-rspec-4.2.4/lib/guard/rspec/formatter.rb:7: warning: previous definition of TEMPORARY_FILE_PATH was here |
@brewster1134 I noticed you use gem 'guard-rspec', github: '907th/guard-rspec', branch: 'fix_247' Its hash is |
@brewster1134 Also try running specs with bundler |
nice catch with the branch! and running specs with bundler was it. i thought running guard through bundler was all that was needed. i look forward to that branch getting merged. thanks |
Fix #247: Use absolute path for temporary file
@brewster1134 @thibaudgg The fix was merged! |
Thanks, 2.4.5 released! @907th what is your rubygems email account? So I can add you to https://rubygems.org/gems/guard-rspec :) |
I saw that this is fixed via using bundler to run rspec, but what if I want to run the tests with Spring? guard :rspec, cmd:'spring rspec' do WIth
|
@kurtfunai I think it was fixed by #261... But it is only in master branch of UPD: I've just released |
@907th thank you, and thanks again for getting back to me so quickly! 😀 |
But it is very interesting question for me: Why do |
@kurtfunai I broke my head trying to reproduce the issue. Can you provide me steps with doing that? I suppose that |
@907th I upgraded to 4.2.9 and it seemed to resolve the issue! I no longer get the double load error. |
@907th the double load is maybe coming from bundler? |
@thibaudgg I think the following happens:
But I was not able to reproduce such behaviour :( I assume that |
@907th thanks for the steps, seems very likely. |
when running my specs, the
rspec_guard_result
is created. some of my specs use chdir and so the file gets created in several places. it seems to only be a summary and is not very helpful.it seems to come from when the guard-rspec specs run... i don't know why (or when) they are even running, but is it possible to disable generating this?
The text was updated successfully, but these errors were encountered: