feat: Move Anghammarad policy into CDK #618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change moves the Anghammarad permissions into the CDK defined stack. The permissions get created as a policy in its own right, rather than statements on a generic "amigo-app" policy. This results in a LOC increase to the resulting CFN template. That is, we're increasing the chance of reaching the CFN template limit! This stack is pretty small, we should adjust strategy only when needed.
jacobwinch
approved these changes
Jun 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #598.
What does this change?
This change moves the Anghammarad permissions into the CDK defined stack.
The permissions get created as a policy in its own right, rather than statements on a generic "amigo-app" policy.
This results in a LOC increase to the resulting CFN template. That is, we're increasing the chance of reaching the CFN template limit!
This stack is pretty small, we should adjust strategy only when needed.
The change set includes changes to
cdk/package.jsonandcdk/yarn.lockbecause@guardian/cdkhas been updated to get the new construct (see guardian/cdk#626).How to test
We only talk to Anghammarad on bake failure at the moment.
I've tested this by creating a bake in CODE that installs an invalid package (filebeat version X.Y.Z). We've successfully received the notification (screenshot below) 🎉 .
Thanks for the suggestion @jacobwinch !
How can we measure success?
We move closer to a CDK only template.