feat: Add policy to allow writing to Anghammarad #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobwinch
approved these changes
Jun 22, 2021
Create a policy that allows `sns:Publish` to the Anghammarad SNS topic.
The Anghammarad SNS topic is used across multiple stacks,
so we can promote it to an account wide ("account/services") parameter store location.
We then wrap this account wide parameter into the `AnghammaradTopicParameter` singleton,
which the policy will add when necessary.
akash1810
force-pushed
the
aa-anghammarad
branch
from
aef0b84 to
18191aa
Compare
|
Just noticed a typo ("am" instead of "an"). Have force pushed that change. Have also enabled auto merge. |
|
🎉 This PR is included in version 19.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Jun 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Create a policy that allows
sns:Publishto the Anghammarad SNS topic.The Anghammarad SNS topic is used across multiple stacks, so we can promote it to an account wide ("account/services") parameter store location.
We then wrap this account wide parameter into the
AnghammaradTopicParametersingleton, which the policy will add when necessary.Does this change require changes to existing projects or CDK CLI?
Yes, they become a little DRYer as they no longer need to define this policy themselves.
Does this change require changes to the library documentation?
Yes and documentation is included.
How to test
Tests have been added that cover:
How can we measure success?
Creating a first class construct for Anghammarad permissions means downstream stacks become DRYer.
(I can also correctly spell Anghammarad!)
Have we considered potential risks?
n/a