Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump @guardian/source library from v3 to v4 #12216

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Conversation

cemms1
Copy link
Contributor

@cemms1 cemms1 commented Aug 27, 2024

What does this change?

Bumps @guardian/source library from v3 to v4

  • source@4.0.0
    • guardian/csnx@dc79048: Adds Guardian Headline 64px typography presets and removes Guardian Headline 70px presets.
    headlineBold64
    headlineLight64
    headlineLightItalic64
    headlineMedium64
    headlineMediumItalic64
    

Fixes conflicting types between Emotion's deps, as outlined in emotion-js/emotion#3141.

Why?

We are several major versions behind in DCR and so are unable to use newer source features until we get up to date

This PR is a re-implementation of #12063 to break it down into smaller chunks for review

Copy link

github-actions bot commented Aug 27, 2024

Size Change: -145 B (-0.02%)

Total Size: 964 kB

Filename Size Change
dotcom-rendering/dist/1159.client.web.********************.js 0 B -2.42 kB (removed) 🏆
dotcom-rendering/dist/1201.client.web.********************.js 0 B -5.14 kB (removed) 🏆
dotcom-rendering/dist/1330.client.web.********************.js 0 B -3.34 kB (removed) 🏆
dotcom-rendering/dist/171.client.web.********************.js 0 B -3.83 kB (removed) 🏆
dotcom-rendering/dist/1804.client.web.********************.js 0 B -3.67 kB (removed) 🏆
dotcom-rendering/dist/1956.client.web.********************.js 0 B -19.3 kB (removed) 🏆
dotcom-rendering/dist/1977.client.web.********************.js 0 B -3.68 kB (removed) 🏆
dotcom-rendering/dist/2195.client.web.********************.js 0 B -2.52 kB (removed) 🏆
dotcom-rendering/dist/2404.client.web.********************.js 0 B -3.58 kB (removed) 🏆
dotcom-rendering/dist/2676.client.web.********************.js 0 B -3.2 kB (removed) 🏆
dotcom-rendering/dist/3145.client.web.********************.js 0 B -4.68 kB (removed) 🏆
dotcom-rendering/dist/3226.client.web.********************.js 0 B -2.72 kB (removed) 🏆
dotcom-rendering/dist/3492.client.web.********************.js 0 B -2.99 kB (removed) 🏆
dotcom-rendering/dist/3678.client.web.********************.js 0 B -3.79 kB (removed) 🏆
dotcom-rendering/dist/3767.client.web.********************.js 0 B -5.81 kB (removed) 🏆
dotcom-rendering/dist/3815.client.web.********************.js 0 B -4.91 kB (removed) 🏆
dotcom-rendering/dist/4176.client.web.********************.js 0 B -4.56 kB (removed) 🏆
dotcom-rendering/dist/4894.client.web.********************.js 0 B -3.65 kB (removed) 🏆
dotcom-rendering/dist/4897.client.web.********************.js 0 B -3.96 kB (removed) 🏆
dotcom-rendering/dist/4931.client.web.********************.js 0 B -4.7 kB (removed) 🏆
dotcom-rendering/dist/5501.client.web.********************.js 0 B -2.68 kB (removed) 🏆
dotcom-rendering/dist/5716.client.web.********************.js 0 B -4.31 kB (removed) 🏆
dotcom-rendering/dist/5718.client.web.********************.js 0 B -2.93 kB (removed) 🏆
dotcom-rendering/dist/5878.client.web.********************.js 0 B -5.62 kB (removed) 🏆
dotcom-rendering/dist/6003.client.web.********************.js 0 B -3.34 kB (removed) 🏆
dotcom-rendering/dist/631.client.web.********************.js 0 B -4.51 kB (removed) 🏆
dotcom-rendering/dist/6393.client.web.********************.js 0 B -3.03 kB (removed) 🏆
dotcom-rendering/dist/6586.client.web.********************.js 0 B -2.9 kB (removed) 🏆
dotcom-rendering/dist/7256.client.web.********************.js 0 B -3.98 kB (removed) 🏆
dotcom-rendering/dist/7504.client.web.********************.js 0 B -3.06 kB (removed) 🏆
dotcom-rendering/dist/7570.client.web.********************.js 0 B -4.3 kB (removed) 🏆
dotcom-rendering/dist/7628.client.web.********************.js 0 B -3.73 kB (removed) 🏆
dotcom-rendering/dist/769.client.web.********************.js 0 B -5.14 kB (removed) 🏆
dotcom-rendering/dist/781.client.web.********************.js 0 B -6.51 kB (removed) 🏆
dotcom-rendering/dist/7882.client.web.********************.js 0 B -2.68 kB (removed) 🏆
dotcom-rendering/dist/8501.client.web.********************.js 0 B -3.41 kB (removed) 🏆
dotcom-rendering/dist/8626.client.web.********************.js 3.64 kB +2.75 kB (+308.88%) 🆘
dotcom-rendering/dist/8919.client.web.********************.js 0 B -8.77 kB (removed) 🏆
dotcom-rendering/dist/9044.client.web.********************.js 0 B -3.67 kB (removed) 🏆
dotcom-rendering/dist/9174.client.web.********************.js 0 B -3.42 kB (removed) 🏆
dotcom-rendering/dist/9724.client.web.********************.js 0 B -6.42 kB (removed) 🏆
dotcom-rendering/dist/985.client.web.********************.js 0 B -8.76 kB (removed) 🏆
dotcom-rendering/dist/1534.client.web.********************.js 3.41 kB +3.41 kB (new file) 🆕
dotcom-rendering/dist/2000.client.web.********************.js 2.99 kB +2.99 kB (new file) 🆕
dotcom-rendering/dist/21.client.web.********************.js 2.72 kB +2.72 kB (new file) 🆕
dotcom-rendering/dist/2399.client.web.********************.js 4.91 kB +4.91 kB (new file) 🆕
dotcom-rendering/dist/2460.client.web.********************.js 3.58 kB +3.58 kB (new file) 🆕
dotcom-rendering/dist/2670.client.web.********************.js 4.67 kB +4.67 kB (new file) 🆕
dotcom-rendering/dist/2805.client.web.********************.js 8.78 kB +8.78 kB (new file) 🆕
dotcom-rendering/dist/2827.client.web.********************.js 4.7 kB +4.7 kB (new file) 🆕
dotcom-rendering/dist/3012.client.web.********************.js 3.34 kB +3.34 kB (new file) 🆕
dotcom-rendering/dist/3088.client.web.********************.js 3.2 kB +3.2 kB (new file) 🆕
dotcom-rendering/dist/3314.client.web.********************.js 5.81 kB +5.81 kB (new file) 🆕
dotcom-rendering/dist/3330.client.web.********************.js 2.89 kB +2.89 kB (new file) 🆕
dotcom-rendering/dist/3352.client.web.********************.js 3.35 kB +3.35 kB (new file) 🆕
dotcom-rendering/dist/3844.client.web.********************.js 3.68 kB +3.68 kB (new file) 🆕
dotcom-rendering/dist/407.client.web.********************.js 6.51 kB +6.51 kB (new file) 🆕
dotcom-rendering/dist/4097.client.web.********************.js 8.76 kB +8.76 kB (new file) 🆕
dotcom-rendering/dist/4141.client.web.********************.js 3.41 kB +3.41 kB (new file) 🆕
dotcom-rendering/dist/415.client.web.********************.js 2.42 kB +2.42 kB (new file) 🆕
dotcom-rendering/dist/4236.client.web.********************.js 5.14 kB +5.14 kB (new file) 🆕
dotcom-rendering/dist/4375.client.web.********************.js 6.42 kB +6.42 kB (new file) 🆕
dotcom-rendering/dist/4416.client.web.********************.js 3.73 kB +3.73 kB (new file) 🆕
dotcom-rendering/dist/4905.client.web.********************.js 4.31 kB +4.31 kB (new file) 🆕
dotcom-rendering/dist/5017.client.web.********************.js 19.3 kB +19.3 kB (new file) 🆕
dotcom-rendering/dist/6109.client.web.********************.js 3.96 kB +3.96 kB (new file) 🆕
dotcom-rendering/dist/62.client.web.********************.js 2.67 kB +2.67 kB (new file) 🆕
dotcom-rendering/dist/6245.client.web.********************.js 890 B +890 B (new file) 🆕
dotcom-rendering/dist/630.client.web.********************.js 3.02 kB +3.02 kB (new file) 🆕
dotcom-rendering/dist/6481.client.web.********************.js 3.83 kB +3.83 kB (new file) 🆕
dotcom-rendering/dist/6568.client.web.********************.js 4.51 kB +4.51 kB (new file) 🆕
dotcom-rendering/dist/668.client.web.********************.js 3.98 kB +3.98 kB (new file) 🆕
dotcom-rendering/dist/7034.client.web.********************.js 3.66 kB +3.66 kB (new file) 🆕
dotcom-rendering/dist/7620.client.web.********************.js 3.06 kB +3.06 kB (new file) 🆕
dotcom-rendering/dist/7681.client.web.********************.js 2.67 kB +2.67 kB (new file) 🆕
dotcom-rendering/dist/8537.client.web.********************.js 4.56 kB +4.56 kB (new file) 🆕
dotcom-rendering/dist/8878.client.web.********************.js 3.79 kB +3.79 kB (new file) 🆕
dotcom-rendering/dist/9189.client.web.********************.js 4.3 kB +4.3 kB (new file) 🆕
dotcom-rendering/dist/9366.client.web.********************.js 5.62 kB +5.62 kB (new file) 🆕
dotcom-rendering/dist/9374.client.web.********************.js 2.93 kB +2.93 kB (new file) 🆕
dotcom-rendering/dist/9455.client.web.********************.js 3.67 kB +3.67 kB (new file) 🆕
dotcom-rendering/dist/9867.client.web.********************.js 2.52 kB +2.52 kB (new file) 🆕
dotcom-rendering/dist/9890.client.web.********************.js 5.14 kB +5.14 kB (new file) 🆕
ℹ️ View Unchanged
Filename Size Change
dotcom-rendering/dist/1000.client.web.********************.js 999 B 0 B
dotcom-rendering/dist/1026.client.web.********************.js 784 B 0 B
dotcom-rendering/dist/1090.client.web.********************.js 752 B 0 B
dotcom-rendering/dist/1391.client.web.********************.js 725 B 0 B
dotcom-rendering/dist/1476.client.web.********************.js 784 B 0 B
dotcom-rendering/dist/1667.client.web.********************.js 918 B 0 B
dotcom-rendering/dist/1940.client.web.********************.js 507 B 0 B
dotcom-rendering/dist/2310.client.web.********************.js 880 B 0 B
dotcom-rendering/dist/250.client.web.********************.js 2.23 kB 0 B
dotcom-rendering/dist/267.client.web.********************.js 917 B 0 B
dotcom-rendering/dist/2750.client.web.********************.js 438 B 0 B
dotcom-rendering/dist/2780.client.web.********************.js 3.42 kB +2 B (+0.06%)
dotcom-rendering/dist/281.client.web.********************.js 642 B 0 B
dotcom-rendering/dist/2848.client.web.********************.js 618 B 0 B
dotcom-rendering/dist/3109.client.web.********************.js 803 B 0 B
dotcom-rendering/dist/3270.client.web.********************.js 961 B 0 B
dotcom-rendering/dist/3304.client.web.********************.js 853 B 0 B
dotcom-rendering/dist/3521.client.web.********************.js 4.4 kB -8 B (-0.18%)
dotcom-rendering/dist/3751.client.web.********************.js 3.02 kB 0 B
dotcom-rendering/dist/3769.client.web.********************.js 999 B 0 B
dotcom-rendering/dist/3938.client.web.********************.js 4.9 kB -2 B (-0.04%)
dotcom-rendering/dist/4282.client.web.********************.js 685 B 0 B
dotcom-rendering/dist/435.client.web.********************.js 3.69 kB -5 B (-0.14%)
dotcom-rendering/dist/4359.client.web.********************.js 22.7 kB +7 B (+0.03%)
dotcom-rendering/dist/4501.client.web.********************.js 4.29 kB 0 B
dotcom-rendering/dist/4506.client.web.********************.js 9.85 kB +4 B (+0.04%)
dotcom-rendering/dist/4628.client.web.********************.js 654 B 0 B
dotcom-rendering/dist/4941.client.web.********************.js 890 B 0 B
dotcom-rendering/dist/5546.client.web.********************.js 3.77 kB 0 B
dotcom-rendering/dist/5571.client.web.********************.js 13.9 kB +2 B (+0.01%)
dotcom-rendering/dist/5658.client.web.********************.js 750 B 0 B
dotcom-rendering/dist/5757.client.web.********************.js 931 B 0 B
dotcom-rendering/dist/5880.client.web.********************.js 828 B 0 B
dotcom-rendering/dist/6044.client.web.********************.js 726 B 0 B
dotcom-rendering/dist/6071.client.web.********************.js 577 B 0 B
dotcom-rendering/dist/6135.client.web.********************.js 779 B 0 B
dotcom-rendering/dist/6153.client.web.********************.js 2.99 kB -1 B (-0.03%)
dotcom-rendering/dist/6444.client.web.********************.js 4.01 kB -11 B (-0.27%)
dotcom-rendering/dist/6449.client.web.********************.js 9.86 kB 0 B
dotcom-rendering/dist/6505.client.web.********************.js 1 kB 0 B
dotcom-rendering/dist/6598.client.web.********************.js 780 B 0 B
dotcom-rendering/dist/6638.client.web.********************.js 907 B 0 B
dotcom-rendering/dist/6659.client.web.********************.js 1.84 kB 0 B
dotcom-rendering/dist/678.client.web.********************.js 804 B 0 B
dotcom-rendering/dist/6795.client.web.********************.js 523 B 0 B
dotcom-rendering/dist/6989.client.web.********************.js 528 B 0 B
dotcom-rendering/dist/7116.client.web.********************.js 23 kB 0 B
dotcom-rendering/dist/7265.client.web.********************.js 3.22 kB -7 B (-0.22%)
dotcom-rendering/dist/7333.client.web.********************.js 2.25 kB 0 B
dotcom-rendering/dist/7539.client.web.********************.js 3.7 kB -2 B (-0.05%)
dotcom-rendering/dist/7564.client.web.********************.js 6.21 kB +1 B (+0.02%)
dotcom-rendering/dist/7622.client.web.********************.js 155 B 0 B
dotcom-rendering/dist/7673.client.web.********************.js 3.21 kB +1 B (+0.03%)
dotcom-rendering/dist/7691.client.web.********************.js 853 B 0 B
dotcom-rendering/dist/7741.client.web.********************.js 20.2 kB 0 B
dotcom-rendering/dist/83.client.web.********************.js 750 B 0 B
dotcom-rendering/dist/8389.client.web.********************.js 4.1 kB -5 B (-0.12%)
dotcom-rendering/dist/8504.client.web.********************.js 827 B 0 B
dotcom-rendering/dist/8536.client.web.********************.js 595 B 0 B
dotcom-rendering/dist/8697.client.web.********************.js 956 B 0 B
dotcom-rendering/dist/8701.client.web.********************.js 12.6 kB -8 B (-0.06%)
dotcom-rendering/dist/8795.client.web.********************.js 3.83 kB -1 B (-0.03%)
dotcom-rendering/dist/8833.client.web.********************.js 829 B 0 B
dotcom-rendering/dist/9184.client.web.********************.js 493 B 0 B
dotcom-rendering/dist/9241.client.web.********************.js 2.94 kB -7 B (-0.24%)
dotcom-rendering/dist/9493.client.web.********************.js 785 B 0 B
dotcom-rendering/dist/9557.client.web.********************.js 921 B 0 B
dotcom-rendering/dist/9569.client.web.********************.js 43.7 kB -3 B (-0.01%)
dotcom-rendering/dist/9721.client.web.********************.js 717 B 0 B
dotcom-rendering/dist/9835.client.web.********************.js 647 B 0 B
dotcom-rendering/dist/9899.client.web.********************.js 669 B 0 B
dotcom-rendering/dist/Accessibility-importable.client.web.********************.js 5.7 kB -2 B (-0.04%)
dotcom-rendering/dist/AdBlockAsk-importable.client.web.********************.js 2.84 kB -2 B (-0.07%)
dotcom-rendering/dist/AdPortals-importable.client.web.********************.js 3.93 kB -6 B (-0.15%)
dotcom-rendering/dist/AlreadyVisited-importable.client.web.********************.js 421 B 0 B
dotcom-rendering/dist/AppsEpic-importable.client.web.********************.js 3.56 kB -7 B (-0.2%)
dotcom-rendering/dist/AppsFooter-importable.client.web.********************.js 3.65 kB -3 B (-0.08%)
dotcom-rendering/dist/AppsLightboxImage-importable.client.web.********************.js 3.07 kB 0 B
dotcom-rendering/dist/AppsLightboxImageStore-importable.client.web.********************.js 2.5 kB 0 B
dotcom-rendering/dist/AudioAtomWrapper-importable.client.web.********************.js 3.58 kB -1 B (-0.03%)
dotcom-rendering/dist/AustralianTerritorySwitcher-importable.client.web.********************.js 2.58 kB 0 B
dotcom-rendering/dist/Branding-importable.client.web.********************.js 3.05 kB -1 B (-0.03%)
dotcom-rendering/dist/braze-web-sdk-core.client.web.********************.js 37.2 kB 0 B
dotcom-rendering/dist/BrazeMessaging-importable.client.web.********************.js 1.96 kB -1 B (-0.05%)
dotcom-rendering/dist/CalloutBlockComponent-importable.client.web.********************.js 6.71 kB -2 B (-0.03%)
dotcom-rendering/dist/CalloutEmbedBlockComponent-importable.client.web.********************.js 7.35 kB -5 B (-0.07%)
dotcom-rendering/dist/CardCommentCount-importable.client.web.********************.js 3.48 kB +4 B (+0.12%)
dotcom-rendering/dist/Carousel-importable.client.web.********************.js 7.26 kB -4 B (-0.06%)
dotcom-rendering/dist/CarouselForNewsletters-importable.client.web.********************.js 4.5 kB +1 B (+0.02%)
dotcom-rendering/dist/ChartAtom-importable.client.web.********************.js 539 B 0 B
dotcom-rendering/dist/CommentCount-importable.client.web.********************.js 3.3 kB -1 B (-0.03%)
dotcom-rendering/dist/DiscussionApps-importable.client.web.********************.js 1.91 kB 0 B
dotcom-rendering/dist/DiscussionMeta-importable.client.web.********************.js 1.22 kB 0 B
dotcom-rendering/dist/DiscussionWeb-importable.client.web.********************.js 1.74 kB 0 B
dotcom-rendering/dist/DocumentBlockComponent-importable.client.web.********************.js 3.65 kB -2 B (-0.05%)
dotcom-rendering/dist/Dropdown-importable.client.web.********************.js 1.73 kB +1 B (+0.06%)
dotcom-rendering/dist/EditionSwitcherBanner-importable.client.web.********************.js 5.95 kB -2 B (-0.03%)
dotcom-rendering/dist/EmbedBlockComponent-importable.client.web.********************.js 4.27 kB +1 B (+0.02%)
dotcom-rendering/dist/EnhancePinnedPost-importable.client.web.********************.js 2.02 kB 0 B
dotcom-rendering/dist/FetchOnwardsData-importable.client.web.********************.js 2.45 kB -1 B (-0.04%)
dotcom-rendering/dist/FilterKeyEventsToggle-importable.client.web.********************.js 965 B -1 B (-0.1%)
dotcom-rendering/dist/FocusStyles-importable.client.web.********************.js 617 B 0 B
dotcom-rendering/dist/FollowWrapper-importable.client.web.********************.js 763 B 0 B
dotcom-rendering/dist/FooterLabel-importable.client.web.********************.js 348 B 0 B
dotcom-rendering/dist/FooterReaderRevenueLinks-importable.client.web.********************.js 3.74 kB +3 B (+0.08%)
dotcom-rendering/dist/frameworks.client.web.********************.js 20.8 kB 0 B
dotcom-rendering/dist/FrontSubNav-importable.client.web.********************.js 5.45 kB -1 B (-0.02%)
dotcom-rendering/dist/GetCricketScoreboard-importable.client.web.********************.js 6.01 kB +1 B (+0.02%)
dotcom-rendering/dist/GetMatchNav-importable.client.web.********************.js 12 kB 0 B
dotcom-rendering/dist/GetMatchStats-importable.client.web.********************.js 7.99 kB +3 B (+0.04%)
dotcom-rendering/dist/GetMatchTabs-importable.client.web.********************.js 2.71 kB +1 B (+0.04%)
dotcom-rendering/dist/guardian-braze-components-banner.client.web.********************.js 17.3 kB -6 B (-0.03%)
dotcom-rendering/dist/guardian-braze-components-end-of-article.client.web.********************.js 11.6 kB -9 B (-0.08%)
dotcom-rendering/dist/GuideAtomWrapper-importable.client.web.********************.js 3.01 kB +2 B (+0.07%)
dotcom-rendering/dist/HeaderTopBar-importable.client.web.********************.js 7.37 kB -4 B (-0.05%)
dotcom-rendering/dist/HighlightsContainer-importable.client.web.********************.js 4.77 kB -3 B (-0.06%)
dotcom-rendering/dist/index.client.web.********************.js 45.8 kB +4 B (+0.01%)
dotcom-rendering/dist/InstagramBlockComponent-importable.client.web.********************.js 3.29 kB -4 B (-0.12%)
dotcom-rendering/dist/InteractiveAtomMessenger-importable.client.web.********************.js 853 B 0 B
dotcom-rendering/dist/InteractiveBlockComponent-importable.client.web.********************.js 6.33 kB -5 B (-0.08%)
dotcom-rendering/dist/InteractiveContentsBlockComponent-importable.client.web.********************.js 4.73 kB -3 B (-0.06%)
dotcom-rendering/dist/InteractiveSupportButton-importable.client.web.********************.js 6.69 kB 0 B
dotcom-rendering/dist/KeyEventsCarousel-importable.client.web.********************.js 4.76 kB -2 B (-0.04%)
dotcom-rendering/dist/KnowledgeQuizAtom-importable.client.web.********************.js 3.51 kB -5 B (-0.14%)
dotcom-rendering/dist/LatestLinks-importable.client.web.********************.js 4.89 kB -3 B (-0.06%)
dotcom-rendering/dist/LightboxHash-importable.client.web.********************.js 435 B 0 B
dotcom-rendering/dist/LightboxLayout-importable.client.web.********************.js 8.11 kB +2 B (+0.02%)
dotcom-rendering/dist/LiveBlogEpic-importable.client.web.********************.js 3.78 kB -6 B (-0.16%)
dotcom-rendering/dist/LiveblogNotifications-importable.client.web.********************.js 3.15 kB +3 B (+0.1%)
dotcom-rendering/dist/Liveness-importable.client.web.********************.js 5.52 kB -2 B (-0.04%)
dotcom-rendering/dist/ManyNewsletterSignUp-importable.client.web.********************.js 7.86 kB +2 B (+0.03%)
dotcom-rendering/dist/MapEmbedBlockComponent-importable.client.web.********************.js 5.45 kB -3 B (-0.05%)
dotcom-rendering/dist/Metrics-importable.client.web.********************.js 2.68 kB 0 B
dotcom-rendering/dist/MostViewedFooter-importable.client.web.********************.js 5.71 kB +2 B (+0.04%)
dotcom-rendering/dist/MostViewedFooterData-importable.client.web.********************.js 8.34 kB 0 B
dotcom-rendering/dist/MostViewedRightWithAd-importable.client.web.********************.js 4.72 kB +2 B (+0.04%)
dotcom-rendering/dist/OnwardsUpper-importable.client.web.********************.js 5.83 kB -2 B (-0.03%)
dotcom-rendering/dist/PersonalityQuizAtom-importable.client.web.********************.js 3.65 kB -6 B (-0.16%)
dotcom-rendering/dist/ProfileAtom-importable.client.web.********************.js 2.8 kB +2 B (+0.07%)
dotcom-rendering/dist/ProfileAtomWrapper-importable.client.web.********************.js 3.03 kB +2 B (+0.07%)
dotcom-rendering/dist/PulsingDot-importable.client.web.********************.js 750 B 0 B
dotcom-rendering/dist/QandaAtom-importable.client.web.********************.js 2.79 kB +3 B (+0.11%)
dotcom-rendering/dist/ReaderRevenueDev-importable.client.web.********************.js 468 B 0 B
dotcom-rendering/dist/readerRevenueDevUtils.client.web.********************.js 1.97 kB 0 B
dotcom-rendering/dist/RelativeTime-importable.client.web.********************.js 2.53 kB 0 B
dotcom-rendering/dist/RichLinkComponent-importable.client.web.********************.js 5.22 kB 0 B
dotcom-rendering/dist/SecureSignup-importable.client.web.********************.js 5.11 kB +4 B (+0.08%)
dotcom-rendering/dist/SendTargetingParams-importable.client.web.********************.js 2.19 kB 0 B
dotcom-rendering/dist/sentry.client.web.********************.js 766 B 0 B
dotcom-rendering/dist/SetABTests-importable.client.web.********************.js 3.69 kB 0 B
dotcom-rendering/dist/SetAdTargeting-importable.client.web.********************.js 484 B 0 B
dotcom-rendering/dist/ShareButton-importable.client.web.********************.js 1.53 kB 0 B
dotcom-rendering/dist/shimport.client.web.********************.js 2.8 kB 0 B
dotcom-rendering/dist/ShowHideContainers-importable.client.web.********************.js 648 B 0 B
dotcom-rendering/dist/ShowMore-importable.client.web.********************.js 5.54 kB +9 B (+0.16%)
dotcom-rendering/dist/SignInGateMain.client.web.********************.js 4.53 kB +2 B (+0.04%)
dotcom-rendering/dist/SignInGateMainCheckoutComplete.client.web.********************.js 3.92 kB 0 B
dotcom-rendering/dist/SignInGateSelector-importable.client.web.********************.js 3.15 kB 0 B
dotcom-rendering/dist/SlotBodyEnd-importable.client.web.********************.js 3.48 kB -1 B (-0.03%)
dotcom-rendering/dist/SpotifyBlockComponent-importable.client.web.********************.js 5.31 kB -3 B (-0.06%)
dotcom-rendering/dist/StickyBottomBanner-importable.client.web.********************.js 4.19 kB -3 B (-0.07%)
dotcom-rendering/dist/StickyLiveblogAskWrapper-importable.client.web.********************.js 7.64 kB -2 B (-0.03%)
dotcom-rendering/dist/SubNav-importable.client.web.********************.js 3.41 kB +3 B (+0.09%)
dotcom-rendering/dist/SupportTheG-importable.client.web.********************.js 6.59 kB +1 B (+0.02%)
dotcom-rendering/dist/TableOfContents-importable.client.web.********************.js 3.2 kB -2 B (-0.06%)
dotcom-rendering/dist/TimelineAtom-importable.client.web.********************.js 3.23 kB +2 B (+0.06%)
dotcom-rendering/dist/Titlepiece-importable.client.web.********************.js 14.4 kB -2 B (-0.01%)
dotcom-rendering/dist/TopBar-importable.client.web.********************.js 5.4 kB -1 B (-0.02%)
dotcom-rendering/dist/TopBarSupport-importable.client.web.********************.js 2.75 kB 0 B
dotcom-rendering/dist/TweetBlockComponent-importable.client.web.********************.js 1.13 kB -1 B (-0.09%)
dotcom-rendering/dist/UnsafeEmbedBlockComponent-importable.client.web.********************.js 3.3 kB -3 B (-0.09%)
dotcom-rendering/dist/VideoFacebookBlockComponent-importable.client.web.********************.js 5.46 kB -4 B (-0.07%)
dotcom-rendering/dist/VineBlockComponent-importable.client.web.********************.js 3.13 kB -3 B (-0.1%)
dotcom-rendering/dist/WeatherWrapper-importable.client.web.********************.js 7.07 kB +2 B (+0.03%)
dotcom-rendering/dist/YoutubeBlockComponent-importable.client.web.********************.js 3.94 kB -2 B (-0.05%)

compressed-size-action

@cemms1 cemms1 changed the base branch from main to cemms1/bump-source-to-v3 August 27, 2024 16:09
@cemms1 cemms1 added the run_chromatic Runs chromatic when label is applied label Aug 27, 2024
@cemms1 cemms1 marked this pull request as ready for review August 27, 2024 16:12
@cemms1 cemms1 requested review from a team as code owners August 27, 2024 16:12
@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Aug 27, 2024
@cemms1 cemms1 changed the base branch from cemms1/bump-source-to-v3 to main August 27, 2024 16:42
@jamesmockett
Copy link
Contributor

jamesmockett commented Aug 27, 2024

v4 seems to have caused issues with CSS overrides in a handful of places. From a quick look it seems to be where a css prop is being passed to a Source component like here:
https://github.com/guardian/dotcom-rendering/blob/main/dotcom-rendering/src/components/ShareButton.importable.tsx#L152

css seems to be coming from @emotion/react rather than being an explicit prop on LinkButton. Maybe the patch update to @emotion/react in this release has broken this behaviour? 🤔 It should be using cssOverrides in any case. (Or—even better—the theme prop.)

I'll do some testing and try to get to the bottom of this.

@cemms1 cemms1 requested a review from a team as a code owner August 27, 2024 17:35
@cemms1
Copy link
Contributor Author

cemms1 commented Aug 27, 2024

Agree that ShareButton should have been using cssOverrides rather than css prop! I've updated that and also swapped the ThemeProvider for the Button theme prop in the ContributionsEpic components 77f86f7

Will see if this helps with the Chromatic diffs

@tjmw
Copy link
Member

tjmw commented Aug 28, 2024

Hi @cemms1 👋 @guardian/braze-components is consumed by DCR and specifies source as a peer dep (currently wants ^1.0.1 so I think we'll need a new release which bumps the version of source. I can help with that when needed.

@cemms1
Copy link
Contributor Author

cemms1 commented Aug 28, 2024

Hi @cemms1 👋 @guardian/braze-components is consumed by DCR and specifies source as a peer dep (currently wants ^1.0.1 so I think we'll need a new release which bumps the version of source. I can help with that when needed.

Ah thanks Tom! We're trying to bump DCR to v7 of source at the moment. After originally trying to do most of it in one go (#12063) we're now trying to break it down a bit. I wonder how is best to go about updating this in sync

cc. @jamesmockett

@cemms1 cemms1 added the run_chromatic Runs chromatic when label is applied label Aug 28, 2024
@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Aug 28, 2024
@cemms1 cemms1 marked this pull request as draft September 6, 2024 09:53
@cemms1 cemms1 added the run_chromatic Runs chromatic when label is applied label Sep 6, 2024
@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Sep 6, 2024
@cemms1 cemms1 added the run_chromatic Runs chromatic when label is applied label Sep 6, 2024
@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Sep 6, 2024
@cemms1 cemms1 marked this pull request as ready for review September 6, 2024 14:25
Copy link

github-actions bot commented Sep 6, 2024

Hello 👋! When you're ready to run Chromatic, please apply the run_chromatic label to this PR.

You will need to reapply the label each time you want to run Chromatic.

Click here to see the Chromatic project.

@cemms1
Copy link
Contributor Author

cemms1 commented Sep 6, 2024

Those unexpected Chromatic diffs have disappeared, possibly due to matching the peer dependency of braze-components 🤔 or maybe something else. All looks good to continue now 👍

@cemms1 cemms1 merged commit 4e39868 into main Sep 9, 2024
35 checks passed
@cemms1 cemms1 deleted the cemms1/bump-source-to-v4 branch September 9, 2024 10:04
@prout-bot
Copy link

Seen on PROD (merged by @cemms1 9 minutes and 52 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants