-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump @guardian/source
library from v3 to v4
#12216
Conversation
Size Change: -145 B (-0.02%) Total Size: 964 kB
ℹ️ View Unchanged
|
cbeabf1
to
8886932
Compare
530dfc6
to
0d8696b
Compare
v4 seems to have caused issues with CSS overrides in a handful of places. From a quick look it seems to be where a
I'll do some testing and try to get to the bottom of this. |
8886932
to
77f86f7
Compare
Agree that Will see if this helps with the Chromatic diffs |
Ah thanks Tom! We're trying to bump DCR to v7 of source at the moment. After originally trying to do most of it in one go (#12063) we're now trying to break it down a bit. I wonder how is best to go about updating this in sync cc. @jamesmockett |
77f86f7
to
d0597c0
Compare
d0597c0
to
1a24908
Compare
1a24908
to
25040a9
Compare
25040a9
to
359a6cf
Compare
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
Those unexpected Chromatic diffs have disappeared, possibly due to matching the peer dependency of braze-components 🤔 or maybe something else. All looks good to continue now 👍 |
What does this change?
Bumps
@guardian/source
library from v3 to v4Fixes conflicting types between Emotion's deps, as outlined in emotion-js/emotion#3141.
Why?
We are several major versions behind in DCR and so are unable to use newer source features until we get up to date
This PR is a re-implementation of #12063 to break it down into smaller chunks for review