-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump end value of standard cards slice in flex gen #13135
Merged
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: 0 B Total Size: 871 kB ℹ️ View Unchanged
|
7 tasks
github-actions
bot
removed
the
run_chromatic
Runs chromatic when label is applied
label
Jan 14, 2025
Merged
6 tasks
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
abeddow91
approved these changes
Jan 16, 2025
Seen on PROD (merged by @Georges-GNM 12 minutes and 19 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
The upper limit of the number of flexible general stories is being bumped as part of this fronts tool PR (which enables editorial to dynamically set the number of visible stories for flexible general).
The maximum number of stories visible is being limited in by the number of cards in an array in the flexible general component, so we need to increase it in line with the new upper limit of 20.
The only chromatic diffs were for flexible general stories, which are now displaying the maximum of 20 stories (which I'm preferring to setting a limit in the story args, in case this helps surface any issues about the number of stories getting displayed on this container).
Why?
Part of this curation ticket
Screenshots
A flexible general container showing 12 standard stories: