Set maximum number of stories in a flexible general container #27708
+20
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Georges-GNM
force-pushed
the
gl/flex-gen-visible-stories
branch
2 times, most recently
from
73f915f to
1759337
Compare
Georges-GNM
changed the title
Merged
6 tasks
Georges-GNM
force-pushed
the
gl/flex-gen-visible-stories
branch
from
1759337 to
fe09280
Compare
Georges-GNM
force-pushed
the
gl/flex-gen-visible-stories
branch
from
fe09280 to
0bdeb57
Compare
Fweddi
approved these changes
Jan 21, 2025
Thanks, good points! That feels like config tool issues, so will have a look at those there. |
prout-bot
added
Pending-on-ADMIN-PROD
Pending-on-FRONTS-PROD
Seen-on-ADMIN-PROD
and removed
Pending-on-ADMIN-PROD
labels
|
Seen on ADMIN-PROD (merged by @Georges-GNM 11 minutes and 24 seconds ago)
|
|
Seen on FRONTS-PROD (merged by @Georges-GNM 11 minutes and 39 seconds ago)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the value of this and can you measure success?
Closes this fairground ticket, making use of the value getting populated following this fronts tool PR (though that value is effectively optional, so this PR can be merged irrespective of the fronts tool one).
The
maxItemsToDisplayvalue, which is surfaced in thedisplayHintsfield of theCollectionConfig, is now used to set the maximum number of stories appearing in a flexible general collection when it gets pressed.The PR includes a couple of incidental changes, including deleting the FlexibleContainers object which is unused (and most likely was added when the flexible containers were implemented in a symmetrical fashion as the dynamic containers), and some formatting after running
scalafmt.Screenshots
A flexible general container showing only the desired 5 stories from the fronts tool - whereas previously the container would include the pieces below the dividing line in the tool:
Testing
Deploy this to code, and in the fronts tool (running the branch from the above PR), set a specific number of maximum stories for a flexible general container in the config tool. The front should get re-pressed, so checking on the code front, does the desired number of stories get shown?
You can also check the pressed json in s3.
If this DCR branch is running on code (or maybe already merged), you can also confirm larger collections (9+ stories) are displaying the expected number of stories.
Checklist