Add stars for reviews in email fronts #15787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelochlann
requested review from
SiAdcock
and removed request for
davidfurey
|
PR build results: screenshots exceptions (3) webpagetest results -automated message |
SiAdcock
reviewed
Feb 8, 2017
| @card.starRating.map { numberOfStars => | ||
| <div class="review-stars"> | ||
| @for(i <- 0 to 4) { | ||
| @defining(if(i < numberOfStars) "positive" else "negative") { positiveOrNegative => |
There was a problem hiding this comment.
I'm not sure about the use of positive or negative to signify whether the star is yellow or grey... maybe filled / full vs hollow / empty?
There was a problem hiding this comment.
Went for golden and grey for consistency with existing review stars: https://github.com/guardian/frontend/blob/master/common/app/views/fragments/items/elements/starRating.scala.html#L5
|
Seen on PROD (merged by @joelochlann 15 minutes and 48 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cards which have a star rating associated with them will display the stars as they do on web fronts.