Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aria label for star ratings in email #27718

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

mchv
Copy link
Member

@mchv mchv commented Jan 13, 2025

What is the value of this and can you measure success?

Current star ratings in email are not correctly described.
Follow up of #15787

What does this change?

Follow web guidance on accessibility by adding an img role to the span.
See example.

@mchv mchv requested a review from a team as a code owner January 13, 2025 18:17
@mchv mchv added the a11y label Jan 13, 2025
@mchv mchv requested a review from SiAdcock January 14, 2025 09:40
@mchv mchv merged commit a5758f5 into main Jan 14, 2025
6 checks passed
@mchv mchv deleted the mc/email/add-star-rating-arial-label branch January 14, 2025 12:09
@prout-bot
Copy link
Collaborator

Seen on ADMIN-PROD (merged by @mchv 12 minutes and 5 seconds ago)

@prout-bot
Copy link
Collaborator

Seen on FRONTS-PROD (merged by @mchv 12 minutes and 24 seconds ago)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants