Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dev-build following pan-domain-authentication changes #27098

Merged
merged 1 commit into from
May 2, 2024

Conversation

twrichards
Copy link
Contributor

@twrichards twrichards commented May 2, 2024

What is the value of this and can you measure success?

dev-build has been broken since #27012 owing to a missing implementation - this is problematic for devs (in particular @guardian/dotcom-platform

What does this change?

Moves the instantiation of GuardianAuthWithExemptions which was introduced in #27012 up to the AdminControllers trait which is shared by the dev-build and the real AppComponents since they both need it.

Checklist

@twrichards twrichards requested a review from a team as a code owner May 2, 2024 13:18
@twrichards twrichards force-pushed the fix-dev-build-following-pan-domain-authentication branch from 517bdc0 to 8fb5d4b Compare May 2, 2024 15:34
@twrichards twrichards merged commit 0d672b2 into main May 2, 2024
3 checks passed
@twrichards twrichards deleted the fix-dev-build-following-pan-domain-authentication branch May 2, 2024 15:58
@prout-bot
Copy link
Collaborator

Seen on FRONTS-PROD, ADMIN-PROD (merged by @twrichards 13 minutes and 4 seconds ago)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants