wrap admin and preview in pan-domain-authentication 🐼
#27012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twrichards
force-pushed
the
pan-domain-authentication
branch
from
6ea4e63
to
067f65f
Compare
twrichards
force-pushed
the
pan-domain-authentication
branch
6 times, most recently
from
6ad5878
to
2546f48
Compare
rtyley
reviewed
Apr 26, 2024
twrichards
force-pushed
the
pan-domain-authentication
branch
3 times, most recently
from
82a9c1c
to
226bc94
Compare
twrichards
added a commit
to guardian/editorial-viewer
that referenced
this pull request
Apr 30, 2024
…replacing plain Google auth with `pan-domain-authentication` 🐼
…tication` from plain Google auth
twrichards
force-pushed
the
pan-domain-authentication
branch
from
226bc94
to
7977086
Compare
twrichards
added a commit
to guardian/editorial-viewer
that referenced
this pull request
May 1, 2024
mxdvl
approved these changes
May 1, 2024
| )(wsClient, executionContext) | ||
| def healthCheck(): Action[AnyContent] = | ||
| Action { | ||
| Ok("OK") |
Comment on lines
+59
to
+61
| .map(new URI(_)) | ||
| .map(_.getPath) | ||
| .map(DigestUtils.md5Hex) |
| @@ -1,6 +1,15 @@ | |||
| import app.FrontendComponents | |||
| import play.api.ApplicationLoader.Context | |||
| import play.api.BuiltInComponentsFromContext | |||
| import play.api.mvc.EssentialFilter | |||
| import org.scalatestplus.mockito.MockitoSugar | |||
| dev-nginx restart-nginx | ||
|
|
||
| echo -e "💯 Done! You can now run frontend locally on https://${DOMAIN}" | ||
| echo -e "You can also (separately) run admin and preview locally on https://frontend.local.dev-gutools.co.uk and https://preview.local.dev-gutools.co.uk respectively." |
9 tasks
|
Seen on FRONTS-PROD, ADMIN-PROD (merged by @twrichards 14 minutes and 10 seconds ago)
|
twrichards
added a commit
that referenced
this pull request
May 2, 2024
twrichards
added a commit
that referenced
this pull request
May 2, 2024
7 tasks
twrichards
added a commit
that referenced
this pull request
May 2, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
authenticateRequestfunction pan-domain-authentication#137 to be merged and released.preview🐼 editorial-viewer#136 needs to be merged & deployedpan-domain-auth-settingsbucket bypreviewandadminservers are in https://github.com/guardian/platform/pull/1589What is the value of this and can you measure success?
Prior to this PR the
adminandpreviewapps within frontend were wrapped in plain Google auth (since they require a Guardian login to use) - this leaves us at the mercy of Google outages (as occurred recently on 5th March for example). This PR replaces Google auth with our own pan-domain-authentication which wraps Google auth with a handy extra feature to make us resilient to such outages.This also tees us up nicely for adding permissions to
adminandpreviewin #27078What does this change?
Overall this is NET reduction in code 🎉 and a reasonable amount of the diff is splitting/moving things around. A summary of the changes is as follows...
nginx/nginx-mapping.ymlfor use withdev-nginxso thatadminandpreviewcan run onfrontend.local.dev-gutools.co.ukandpreview.local.dev-gutools.co.ukrespectively - so that the pan-domain-authentication actually works (won't work when running purely on localhost)GoogleAuthFiltersin common, to the more fittingGuardianAuthWithExemptionscom.gu.play-googleauthlib withpan-domain-auth-play_3-0(and removes the now unnecessarycom.gu.play-secret-rotationandcom.gu.play-secret-rotation)GuardianAuthWithExemptionsinadminandpreview'sAppLoadersGuardianAuthWithExemptionsPanDomainAuthSettingsRefresherwhich is central to how panda worksfilterproperty which implementsplay.api.mvc.Filter(for use in admin and preview's lists of filters similar to howGoogleAuthFilterswas used beforepreviewandadmin(LOG ONLY) #27078 and actually enforce new permissions foradminandpreview#27092AdminAuthActionreplaces uses of it with regularActionsince the filter should be enforcing auth more broadlyScreenshots
N/A
Checklist