Upgrade to Panda v7 - support key rotation #27493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
7 tasks
rtyley
force-pushed
the
upgrade-to-panda-v7-support-key-rotation
branch
from
73841e1
to
6d93f23
Compare
This upgrades Panda from v5 to v7, allowing us to use key rotation as introduced with guardian/pan-domain-authentication#150. See also guardian/pan-domain-authentication#160.
rtyley
force-pushed
the
upgrade-to-panda-v7-support-key-rotation
branch
from
6d93f23
to
65226f6
Compare
rtyley
commented
Sep 19, 2024
Comment on lines
-57
to
+61
| override lazy val panDomainSettings = | ||
| new PanDomainAuthSettingsRefresher( | ||
| domain = toolsDomainSuffix, | ||
| system, | ||
| bucketName = "pan-domain-auth-settings", | ||
| settingsFileKey = s"$toolsDomainSuffix.settings", | ||
| s3Client, | ||
| ) | ||
| override lazy val panDomainSettings = PanDomainAuthSettingsRefresher( | ||
| domain = toolsDomainSuffix, | ||
| system, | ||
| S3BucketLoader.forAwsSdkV1(s3Client, "pan-domain-auth-settings"), | ||
| ) |
There was a problem hiding this comment.
This PR:
...introduced the new S3BucketLoader abstraction, which simplifies constructing a PanDomainAuthSettingsRefresher and means that Panda is no longer tied to AWS SDK v1 - an alternative AWS SDK v2 implementation of S3BucketLoader could be introduced.
prout-bot
added
Pending-on-ADMIN-PROD
Pending-on-FRONTS-PROD
Seen-on-FRONTS-PROD
and removed
Pending-on-FRONTS-PROD
labels
|
Seen on FRONTS-PROD (merged by @rtyley 12 minutes and 7 seconds ago)
|
|
Seen on ADMIN-PROD (merged by @rtyley 12 minutes and 13 seconds ago)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades Panda from v5 to v7, allowing us to use key rotation as introduced with guardian/pan-domain-authentication#150.
S3BucketLoaderabstraction, which simplifies constructing aPanDomainAuthSettingsRefresherand means that Panda is no longer tied to AWS SDK v1 - an alternative AWS SDK v2 implementation ofS3BucketLoadercould be introduced.See also:
Panda was re-introduced to Frontend with #27012 in May 2024, where it became the authentication system around pages like https://frontend.gutools.co.uk/.
Testing
This has been successfully deployed to CODE, and I've verified that I can successfully re-authenticate at https://frontend.code.dev-gutools.co.uk/admin:
Screen.Recording.2024-09-17.at.12.42.11.mov