expose an authenticateRequest function
#137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
twrichards
force-pushed
the
expose-authenticateRequest-method
branch
from
56ad552
to
a4e1d58
Compare
…tion` which can be called with a `RequestHeader` allowing it to be used in play filters for example
twrichards
force-pushed
the
expose-authenticateRequest-method
branch
from
a4e1d58
to
7c182f8
Compare
|
guardian/frontend#27012 is all working nicely locally, so need to release this library version asap before I can test frontend changes in CODE (and release) |
andrew-nowak
approved these changes
Apr 25, 2024
bryophyta
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...on
AuthAction&APIAuthActionwhich can be called with aRequestHeaderallowing it to be used in play filters for example.frontend uses play filters to ensure all of
previewandadminendpoints are wrapped in auth... in guardian/frontend#27012 we replace plain Google auth with pan-domain-authentication, but filters only deal inRequestHeader(understandably) but it would be useful to be able to reuse all of the authentication and redirect logic in theAuthAction, fortunately this was relatively straigh-forward (and is solving the problem when published locally).