-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make holiday stops flow responsive #267
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cf31016
to
ac9e2ef
Compare
…iday-stop-api (since it doesn't use AsyncLoader)
arausuy
previously approved these changes
Sep 9, 2019
…finite mode' (i.e. loads of vertically stacked cals)
…cted, to ensure spinner always shows during call to /potential
8212595
to
d8c61c9
Compare
Reviewed at desks 👍 Thanks for the PR write up! |
arausuy
approved these changes
Sep 9, 2019
Seen on PROD (merged by @twrichards 4 minutes and 16 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR encompasses all the changes to make the holiday stop flow introduced in #227 responsive across different devices in accordance with the wireframes/designs provided.
Notes
There are a few additional changes and refactors to bring about the responsiveness screenshotted further down...
401
handling for calls toholiday-stop-api
in alignment with the wayAsyncLoader
handles these scenarios (e.g. when the user tries to select some holiday dates, but the users session has gone over one hour, then redirect toreauthenticate
)onefinestay/react-daterange-picker
to achieve an 'infinite' scroll type experiencetouchStart
handler when presenting many calendars stacked (as we do now for mobile) this was causing dates to be selected while scrolling, this was fixed by addingonTouchStartCapture={e => e.stopPropagation()}
on the parent container, which catches the event on the way down to the child component (solved by understanding the capture/target/bubbling lifecycle of events - see https://javascript.info/bubbling-and-capturing#capturing)isStartOrEndVisible
function with() => true
whenthis.props.numberOfCalendars > 12
Holiday Overview Screen
Holiday Date Chooser Screen
Holiday Review Screen
Holiday Confirmation Screen