fixed internal button padding on IE #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twrichards
force-pushed
the
fix-button-padding-IE
branch
from
8364a13
to
80082f3
Compare
rBangay
approved these changes
Nov 19, 2019
|
Seen on PROD (merged by @twrichards 5 minutes and 23 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a regression introduced in #267 - that was a hectic time.
Prior to the above regression the Button component had a
line-heightto make it work on IE (see 3de4285#diff-5afa62adc28365a0ece2481e3bc1a7afL122 specifically). However that made the wrapping quite funky and so it was phased out in the above commit.In order to fix the regression it now specifies the
heightas well as themin-heightwhich allows thealign-items: centerto actually work... because IE 🙈(see philipwalton/flexbugs#231).This is a better solution than using
line-heightdue to its effect on wrapping buttons with long labels.