Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Followed the steps to add gh-scala release #30

Merged

Conversation

Divs-B
Copy link
Contributor

@Divs-B Divs-B commented Jan 10, 2024

ref: https://github.com/guardian/gha-scala-library-release-workflow/blob/main/docs/configuration.md

Note that CI is currently failing on this PR (because CI is failing on main, see #31 ) but are passing on #28 (which performs a Typescript upgrade that somehow fixes the tests).

@rtyley
Copy link
Member

rtyley commented Jan 10, 2024

Note that we paused this work because the tests fail on the default main branch - and there is actually no CI configured for this project.

@rtyley rtyley mentioned this pull request Jan 11, 2024
@rtyley rtyley changed the base branch from main to add-github-actions-ci January 11, 2024 11:52
@rtyley rtyley force-pushed the db-rt/updating-to-gh-scala-lib-release branch from 6bc9764 to 75e6d07 Compare January 11, 2024 11:54
Copy link

Test Results

11 tests  ±0   5 ✅ ±0   24s ⏱️ ±0s
 1 suites ±0   0 💤 ±0 
 1 files   ±0   6 ❌ ±0 

For more details on these failures, see this check.

Results for commit 75e6d07. ± Comparison against base commit 0a21d64.

@rtyley
Copy link
Member

rtyley commented Jan 11, 2024

Now that we have CI in place (with #31) I think we want to merge this PR, to make evaluating #28 (the PR that fixes the tests) easier by supporting a preview release.

@rtyley rtyley marked this pull request as ready for review January 11, 2024 12:07
@rtyley rtyley requested a review from a team as a code owner January 11, 2024 12:07
Copy link
Member

@rtyley rtyley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me - and as discussed, although CI is failing, that's not the fault of this branch, so we should be good to merge this PR!

@Divs-B Divs-B merged commit 5a6b5b9 into add-github-actions-ci Jan 11, 2024
0 of 2 checks passed
@rtyley
Copy link
Member

rtyley commented Jan 12, 2024

I managed to lose the changes from being merged to main by switching the PR base branch, but have fixed it now with commit 7efe16c!

@rtyley rtyley mentioned this pull request Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants