-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Followed the steps to add gh-scala release #30
Followed the steps to add gh-scala release #30
Conversation
Note that we paused this work because the tests fail on the default |
6bc9764
to
75e6d07
Compare
Test Results11 tests ±0 5 ✅ ±0 24s ⏱️ ±0s For more details on these failures, see this check. Results for commit 75e6d07. ± Comparison against base commit 0a21d64. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me - and as discussed, although CI is failing, that's not the fault of this branch, so we should be good to merge this PR!
I managed to lose the changes from being merged to |
ref: https://github.com/guardian/gha-scala-library-release-workflow/blob/main/docs/configuration.md
Note that CI is currently failing on this PR (because CI is failing on
main
, see #31 ) but are passing on #28 (which performs a Typescript upgrade that somehow fixes the tests).