Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release process #33

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Fix release process #33

merged 1 commit into from
Jan 18, 2024

Conversation

Divs-B
Copy link
Contributor

@Divs-B Divs-B commented Jan 18, 2024

What does this change?

Some of settings that are not required under gha-scala-workflow release process has been removed - these additional settings broke the release process after #30, as can be seen here:

https://github.com/guardian/scrooge-extras/actions/runs/7573680653/job/20626419324

image

Readme release description updated.

How to test

Make a release once the PR is reviewed and merged.

How can we measure success?

release process should run smoothly.

Some of settings that are not required under gha-scala-workflow release process has been removed

Readme release description updated.
@Divs-B Divs-B requested a review from a team as a code owner January 18, 2024 17:54
@Divs-B Divs-B requested a review from rtyley January 18, 2024 17:54
Copy link

Test Results

11 tests   11 ✅  26s ⏱️
 1 suites   0 💤
 1 files     0 ❌

Results for commit 2aee814.

Copy link
Member

@rtyley rtyley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've looked at the whole build.sbt file this time - it looks good I think - should have done that when I was reviewing #30 !

@rtyley rtyley merged commit be22398 into main Jan 18, 2024
2 checks passed
@rtyley
Copy link
Member

rtyley commented Jan 18, 2024

We've run a new release, and it looks to be working well with the fixes from this PR:

https://github.com/guardian/scrooge-extras/actions/runs/7574126488

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants