Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge brute force and vulnerability exploiters in the configuration #2787

Closed
11 tasks done
mssalvatore opened this issue Jan 5, 2023 · 0 comments · Fixed by #2796
Closed
11 tasks done

Merge brute force and vulnerability exploiters in the configuration #2787

mssalvatore opened this issue Jan 5, 2023 · 0 comments · Fixed by #2796
Labels
Complexity: Medium Impact: High Plugins Refactor

Comments

@mssalvatore
Copy link
Collaborator

mssalvatore commented Jan 5, 2023 •
edited
Loading

Description

The separation between brute force and vulnerability exploiters was based on the use case of "vulnerability scanning", which is no longer Infection Monkey's main goal. Ultimately, users should be able to configure the order that exploiters run in. While the UI doesn't allow this at the moment, the configuration can be manipulated manually to achieve this. However, vulnerability exploiters always run before brute force exploiters. In other words, this separation reduces the configurability of the system.

Note

To avoid breaking develop, base all work off of 2787-merge-vulnerability-and-brute-force-exploiter-config.

Tasks

  • Modify the AgentConfiguration object to contain only "Exploiters` (0d) @mssalvatore
    • Pydantic object
    • Unit tests
    • Default configuration
  • Modify the UI to comply with the new configuration (0d) @ilija-lazoroski
    • UI Schema
    • SafeOptionValidator
  • Modify the logic in infection_monkey.master.exploiter to use the new configuration (0d) @mssalvatore
  • Modify the logic in monkey_island.cc.services.reporting.report to use the new configuration (0d) @ilija-lazoroski
  • Modify the path_in_schema in the AgentConfigurationSchemaService (0d) @ilija-lazoroski
  • Fix BB tests (0d)
@VakarisZ VakarisZ mentioned this issue Jan 5, 2023
Closed
14 tasks
mssalvatore added a commit that referenced this issue Jan 5, 2023
@mssalvatore
Agent: Merge "brute_force" and "vulnerability" into "exploiters"
1644610 
The separation between brute force and vulnerability exploiters was
based on the use case of "vulnerability scanning", which is no longer
Infection Monkey's main goal. Ultimately, users should be able to
configure the order that exploiters run in. While the UI doesn't allow
this at the moment, the configuration can be manipulated manually to
achieve this. However, vulnerability exploiters always run before brute
force exploiters. In other words, this separation reduces the
configurability of the system.

By merging these into a single list of exploiters, we allow the user to
have total control over the order in which exploiters are run.

Issue #2787
@mssalvatore mssalvatore mentioned this issue Jan 5, 2023
Merged
8 tasks
mssalvatore added a commit that referenced this issue Jan 5, 2023
@mssalvatore
Agent: Merge "brute_force" and "vulnerability" into "exploiters"
a1e57d9 
The separation between brute force and vulnerability exploiters was
based on the use case of "vulnerability scanning", which is no longer
Infection Monkey's main goal. Ultimately, users should be able to
configure the order that exploiters run in. While the UI doesn't allow
this at the moment, the configuration can be manipulated manually to
achieve this. However, vulnerability exploiters always run before brute
force exploiters. In other words, this separation reduces the
configurability of the system.

By merging these into a single list of exploiters, we allow the user to
have total control over the order in which exploiters are run.

Issue #2787
PR #2789
@mssalvatore mssalvatore mentioned this issue Jan 5, 2023
Merged
8 tasks
cakekoa pushed a commit that referenced this issue Jan 5, 2023
@mssalvatore @cakekoa
Agent: Merge "brute_force" and "vulnerability" into "exploiters"
143b1da 
The separation between brute force and vulnerability exploiters was
based on the use case of "vulnerability scanning", which is no longer
Infection Monkey's main goal. Ultimately, users should be able to
configure the order that exploiters run in. While the UI doesn't allow
this at the moment, the configuration can be manipulated manually to
achieve this. However, vulnerability exploiters always run before brute
force exploiters. In other words, this separation reduces the
configurability of the system.

By merging these into a single list of exploiters, we allow the user to
have total control over the order in which exploiters are run.

Issue #2787
PR #2789
mssalvatore added a commit that referenced this issue Jan 5, 2023
@mssalvatore
Merge branch '2787-modify-master-exploiter-logic' into 2787-merge-vul…
90251de 
…nerability-and-brute-force-exploiter-config

Issue #2787
PR #2790
This was referenced Jan 6, 2023
Merged
Merged
ilija-lazoroski added a commit that referenced this issue Jan 6, 2023
@ilija-lazoroski
Island: Modify report generation to work with merged exploiters
a8f4591 
Issue: #2787
PR: #2795
ilija-lazoroski added a commit that referenced this issue Jan 6, 2023
@ilija-lazoroski
Island: Modify report generation to work with merged exploiters
ca0c322 
Issue: #2787
PR: #2795
VakarisZ pushed a commit that referenced this issue Jan 6, 2023
@ilija-lazoroski @VakarisZ
Island: Modify report generation to work with merged exploiters
571099c 
Issue: #2787
PR: #2795
@ilija-lazoroski ilija-lazoroski mentioned this issue Jan 6, 2023
Merged
8 tasks
ilija-lazoroski pushed a commit that referenced this issue Jan 6, 2023
@mssalvatore @ilija-lazoroski
Agent: Merge "brute_force" and "vulnerability" into "exploiters"
0e176d2 
The separation between brute force and vulnerability exploiters was
based on the use case of "vulnerability scanning", which is no longer
Infection Monkey's main goal. Ultimately, users should be able to
configure the order that exploiters run in. While the UI doesn't allow
this at the moment, the configuration can be manipulated manually to
achieve this. However, vulnerability exploiters always run before brute
force exploiters. In other words, this separation reduces the
configurability of the system.

By merging these into a single list of exploiters, we allow the user to
have total control over the order in which exploiters are run.

Issue #2787
PR #2789
ilija-lazoroski added a commit that referenced this issue Jan 6, 2023
@ilija-lazoroski
Island: Modify report generation to work with merged exploiters
9584584 
Issue: #2787
PR: #2795
ilija-lazoroski added a commit that referenced this issue Jan 6, 2023
@ilija-lazoroski
BB: Modify test configuration with merged exploiters
eaa9901 
Issue: #2787
@ilija-lazoroski ilija-lazoroski mentioned this issue Jan 6, 2023
Merged
8 tasks
ilija-lazoroski added a commit that referenced this issue Jan 6, 2023
@ilija-lazoroski
BB: Modify test configuration with merged exploiters
7861245 
Issue: #2787
PR: #2797
mssalvatore pushed a commit that referenced this issue Jan 6, 2023
@ilija-lazoroski @mssalvatore
BB: Modify test configuration with merged exploiters
20257f5 
Issue: #2787
PR: #2797
mssalvatore added a commit that referenced this issue Jan 6, 2023
@mssalvatore
Agent: Merge "brute_force" and "vulnerability" into "exploiters"
57d5d87 
The separation between brute force and vulnerability exploiters was
based on the use case of "vulnerability scanning", which is no longer
Infection Monkey's main goal. Ultimately, users should be able to
configure the order that exploiters run in. While the UI doesn't allow
this at the moment, the configuration can be manipulated manually to
achieve this. However, vulnerability exploiters always run before brute
force exploiters. In other words, this separation reduces the
configurability of the system.

By merging these into a single list of exploiters, we allow the user to
have total control over the order in which exploiters are run.

Issue #2787
PR #2789
mssalvatore pushed a commit that referenced this issue Jan 6, 2023
@ilija-lazoroski @mssalvatore
Island: Modify report generation to work with merged exploiters
2d0aaf9 
Issue: #2787
PR: #2795
mssalvatore pushed a commit that referenced this issue Jan 6, 2023
@ilija-lazoroski @mssalvatore
BB: Modify test configuration with merged exploiters
3db41de 
Issue: #2787
PR: #2797
mssalvatore added a commit that referenced this issue Jan 6, 2023
@mssalvatore
Merge branch '2787-merge-vulnerability-and-brute-force-exploiter-conf…
d0d4b8b 
…ig' into develop

Issue #2787
PR #2796
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Complexity: Medium Impact: High Plugins Refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

2787 merge vulnerability and brute force exploiter config guardicore/monkey
1 participant
@mssalvatore